Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: make memory leak warning name more verbose #8341

Closed
wants to merge 1 commit into from
Closed

events: make memory leak warning name more verbose #8341

wants to merge 1 commit into from
+3 −2

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Aug 30, 2016 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

events

Description of change

Switch from a generic Warning to the more specific MaxListenersExceededWarning, as suggested in #8298 (separate PR for this because this is a semver-major change).

CI: https://ci.nodejs.org/job/node-test-commit/4842/

@addaleax
events: make memory leak warning name more verbose
a6b6114 
Switch from a generic `Warning` to the more specific
`MaxListenersExceededWarning`.

Ref: nodejs#8298
@addaleax addaleax added events Issues and PRs related to the events subsystem / EventEmitter. semver-major PRs that contain breaking changes and should be released in the next major version. labels Aug 30, 2016
@jasnell
Copy link
Member

jasnell commented Aug 30, 2016

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Aug 30, 2016

LGTM

@evanlucas
Copy link
Contributor

lgtm

@addaleax
Copy link
Member Author

addaleax commented Sep 4, 2016

Landed in 983775d

@addaleax addaleax closed this Sep 4, 2016
@addaleax addaleax deleted the event-emitter-warning-name branch September 4, 2016 15:26
addaleax added a commit that referenced this pull request Sep 4, 2016
@addaleax
events: make memory leak warning name more verbose
983775d 
Switch from a generic `Warning` to the more specific
`MaxListenersExceededWarning`.

Ref: #8298
PR-URL: #8341
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
events Issues and PRs related to the events subsystem / EventEmitter. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @jasnell @cjihrig @evanlucas