Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update targos email in readme per request #8389

Closed
wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Sep 2, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Update @targos' email in readme per request.

@jasnell jasnell added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Sep 2, 2016
@addaleax
Copy link
Member

addaleax commented Sep 2, 2016

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Sep 2, 2016

LGTM. Seems like something @targos should do though.

@jasnell
Copy link
Member Author

jasnell commented Sep 2, 2016

@cjihrig ... he asked me to since I was working on updating the authors list anyway... #8346 (comment)

@cjihrig
Copy link
Contributor

cjihrig commented Sep 2, 2016

I know. Just making an observation.

@jasnell
Copy link
Member Author

jasnell commented Sep 2, 2016

I'm gonna go out on a limb and say this one is likely trivial and doesn't need to wait the 48 hours.

@cjihrig
Copy link
Contributor

cjihrig commented Sep 2, 2016

Agreed

jasnell added a commit that referenced this pull request Sep 2, 2016
PR-URL: #8389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Sep 2, 2016

Landed in ced2bc3

@jasnell jasnell closed this Sep 2, 2016
@targos
Copy link
Member

targos commented Sep 2, 2016

Thank you. I wasn't expecting so much 😊

@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
PR-URL: nodejs#8389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
PR-URL: #8389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
PR-URL: #8389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
PR-URL: #8389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #8389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #8389
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants