src: update module version mismatch error message #8391

jasnell · 2016-09-02T18:57:35Z

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

src

Description of change

Fixes: #8379

addaleax · 2016-09-02T18:59:48Z

It might be kind of cool to have the file name in there, too.

LGTM with or without that

jasnell · 2016-09-02T19:06:06Z

I don't believe there's currently a way of testing this in our CI but... just to make sure I didn't break anything: https://ci.nodejs.org/job/node-test-pull-request/3929/

targos · 2016-09-02T19:07:15Z

src/node.cc

+             "This module was compiled against a different Node.js version "
+             "using NODE_MODULE_VERSION %d. This version of Node.js requires "
+             "NODE_MODULE_VERSION %d. Please try re-compiling or re-installing "
+             "the module (for instance, using `npm install` or `npm rebuild`).",


I would use the same order than the line before: npm rebuild corresponds to re-compiling and npm install to re-installing.

Good catch :-)

targos · 2016-09-02T19:09:21Z

Did you try locally with a manual bump of NODE_MODULE_VERSION ?

jasnell · 2016-09-02T19:10:32Z

before adding the *filename in the latest bump, yes. Will need to try it again in just a bit.

addaleax · 2016-09-02T19:33:52Z

If you want CI testing for this, an addon like this should always fail when require()ing it:

#include <node_version.h>
#undef NODE_MODULE_VERSION
#define NODE_MODULE_VERSION 42
#include <node.h>

namespace {

inline void Initialize(v8::Local<v8::Object> exports,
                       v8::Local<v8::Value> module,
                       v8::Local<v8::Context> context) {
}

}

NODE_MODULE_CONTEXT_AWARE(binding, Initialize)

jasnell · 2016-09-02T19:44:55Z

Added a quick test case! Thanks @addaleax :-)

addaleax · 2016-09-02T19:57:22Z

CI: https://ci.nodejs.org/job/node-test-commit/4888/ :)

Fishrock123 · 2016-09-02T21:02:42Z

src/node.cc

+             "The module '%s' was compiled against a different Node.js version "
+             "using NODE_MODULE_VERSION %d. This version of Node.js requires "
+             "NODE_MODULE_VERSION %d. Please try re-compiling or re-installing "
+             "the module (for instance, using `npm rebuild` or `npm install`).",


Some line breaks would be nice.

Line breaks added

jasnell · 2016-09-04T17:06:52Z

CI green except for known flaky

benjamingr · 2016-09-04T21:25:24Z

LGTM

Fishrock123 · 2016-09-06T14:19:26Z

src/node.cc

@@ -2402,8 +2402,11 @@ void DLOpen(const FunctionCallbackInfo<Value>& args) {
    char errmsg[1024];
    snprintf(errmsg,
             sizeof(errmsg),
-             "Module version mismatch. Expected %d, got %d.",
-             NODE_MODULE_VERSION, mp->nm_version);
+             "The module '%s' was compiled against a different Node.js version"


I think it may be useful to split after the module name, e.g. output can currently become:

Error: The module '/Users/Jeremiah/Documents/node/test/addons/node-module-version/build/Release/binding.node' was compiled against a different Node.js version using NODE_MODULE_VERSION 42. This version of Node.js requires NODE_MODULE_VERSION 48. Please try re-compiling or re-installing the module (for instance, using `npm rebuild` or`npm install`).

which renders as

Error: The module '/Users/Jeremiah/Documents/node/test/addons/node-module- version/build/Release/binding.node' was compiled against a different Node.js version using NODE_MODULE_VERSION 42. This version of Node.js requires NODE_MODULE_VERSION 48. Please try re-compiling or re-installing the module (for instance, using `npm rebuild` or`npm install`).

addaleax · 2016-09-24T21:16:47Z

hm, ping @jasnell? Jeremiah’s suggestion sounds good to me.

jasnell · 2016-09-26T14:59:31Z

Yep, agreed. Just haven't been able to get back to it yet. Will try to update this later today.

jasnell · 2016-09-27T17:10:59Z

Updated, PTAL

cjihrig · 2016-09-27T17:24:10Z

test/addons/node-module-version/test.js

+const assert = require('assert');
+
+assert.throws(() => require('./build/Release/binding'),
+              /was compiled against a different Node.js version/);


Could you add the module versions to the error message check?

Fixes: nodejs#8379

jasnell · 2016-10-08T16:25:55Z

@cjihrig ... PTAL

jasnell · 2016-10-08T16:34:28Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/4436/

Fixes: #8379 PR-URL: #8391 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

jasnell · 2016-10-10T15:58:10Z

Landed in a6e1be4.
@nodejs/ctc ... any objections to this landing in v7.x?

Fixes: #8379 PR-URL: #8391 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

jasnell added module Issues and PRs related to the module subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. lib / src Issues and PRs related to general changes in the lib or src directory. error-handling labels Sep 2, 2016

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 2, 2016

jasnell mentioned this pull request Sep 2, 2016

Not helpful error message after upgrading Node #8379

Closed

targos reviewed Sep 2, 2016
View reviewed changes

Fishrock123 reviewed Sep 2, 2016
View reviewed changes

jasnell force-pushed the module_version_mismatch branch from 2e042f5 to 47dfb13 Compare September 2, 2016 21:25

Fishrock123 reviewed Sep 6, 2016
View reviewed changes

Trott force-pushed the master branch from b0df363 to c5ce7f4 Compare September 21, 2016 00:09

jasnell force-pushed the module_version_mismatch branch from 47dfb13 to b3a40fd Compare September 27, 2016 17:09

cjihrig reviewed Sep 27, 2016

View reviewed changes

src: update module version mismatch error message

a1abcd4

Fixes: nodejs#8379

jasnell force-pushed the module_version_mismatch branch from b3a40fd to a1abcd4 Compare October 8, 2016 16:24

cjihrig approved these changes Oct 8, 2016

View reviewed changes

jasnell closed this Oct 10, 2016

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

This was referenced Mar 9, 2024

[Snyk] Upgrade @typescript-eslint/eslint-plugin from 6.21.0 to 7.0.1 B020239/node#2

Open

[Snyk] Upgrade @typescript-eslint/parser from 6.21.0 to 7.0.1 B020239/node#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src: update module version mismatch error message #8391

src: update module version mismatch error message #8391

jasnell commented Sep 2, 2016

addaleax commented Sep 2, 2016

jasnell commented Sep 2, 2016

targos Sep 2, 2016

jasnell Sep 2, 2016

targos commented Sep 2, 2016

jasnell commented Sep 2, 2016

addaleax commented Sep 2, 2016

jasnell commented Sep 2, 2016

addaleax commented Sep 2, 2016

Fishrock123 Sep 2, 2016

jasnell Sep 2, 2016

jasnell commented Sep 4, 2016

benjamingr commented Sep 4, 2016

Fishrock123 Sep 6, 2016 •

edited

Loading

addaleax commented Sep 24, 2016

jasnell commented Sep 26, 2016

jasnell commented Sep 27, 2016

cjihrig Sep 27, 2016

jasnell Oct 8, 2016

jasnell commented Oct 8, 2016

jasnell commented Oct 8, 2016

jasnell commented Oct 10, 2016

src: update module version mismatch error message #8391

src: update module version mismatch error message #8391

Conversation

jasnell commented Sep 2, 2016

Checklist

Affected core subsystem(s)

Description of change

addaleax commented Sep 2, 2016

jasnell commented Sep 2, 2016

targos Sep 2, 2016

Choose a reason for hiding this comment

jasnell Sep 2, 2016

Choose a reason for hiding this comment

targos commented Sep 2, 2016

jasnell commented Sep 2, 2016

addaleax commented Sep 2, 2016

jasnell commented Sep 2, 2016

addaleax commented Sep 2, 2016

Fishrock123 Sep 2, 2016

Choose a reason for hiding this comment

jasnell Sep 2, 2016

Choose a reason for hiding this comment

jasnell commented Sep 4, 2016

benjamingr commented Sep 4, 2016

Fishrock123 Sep 6, 2016 • edited Loading

Choose a reason for hiding this comment

addaleax commented Sep 24, 2016

jasnell commented Sep 26, 2016

jasnell commented Sep 27, 2016

cjihrig Sep 27, 2016

Choose a reason for hiding this comment

jasnell Oct 8, 2016

Choose a reason for hiding this comment

jasnell commented Oct 8, 2016

jasnell commented Oct 8, 2016

jasnell commented Oct 10, 2016

Fishrock123 Sep 6, 2016 •

edited

Loading