test: add test-debug-protocol-execute #8454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test for `Protocol` object in `_debugger` module. This test covers some edge cases that fill some coverage gaps in our testing (such as the "Unknown state" error).
|
|
||
| require('../common'); | ||
| const assert = require('assert'); | ||
| const debug = require('_debugger'); |
There was a problem hiding this comment.
Missed opportunity to write const { Protocol } = require('_debugger'); :-)
|
LGTM |
1 similar comment
|
LGTM |
|
Only CI failures are two known flakies, one with an imminent fix, and one being actively worked on. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 12, 2016
Add test for `Protocol` object in `_debugger` module. This test covers some edge cases that fill some coverage gaps in our testing (such as the "Unknown state" error). PR-URL: nodejs#8454 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 5282f0b |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
Add test for `Protocol` object in `_debugger` module. This test covers some edge cases that fill some coverage gaps in our testing (such as the "Unknown state" error). PR-URL: #8454 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
Add test for `Protocol` object in `_debugger` module. This test covers some edge cases that fill some coverage gaps in our testing (such as the "Unknown state" error). PR-URL: #8454 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Add test for `Protocol` object in `_debugger` module. This test covers some edge cases that fill some coverage gaps in our testing (such as the "Unknown state" error). PR-URL: #8454 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Add test for `Protocol` object in `_debugger` module. This test covers some edge cases that fill some coverage gaps in our testing (such as the "Unknown state" error). PR-URL: #8454 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Add test for `Protocol` object in `_debugger` module. This test covers some edge cases that fill some coverage gaps in our testing (such as the "Unknown state" error). PR-URL: #8454 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test debugger
Description of change
Add test for
Protocolobject in_debuggermodule. This test coverssome edge cases that fill some coverage gaps in our testing (such as the
"Unknown state" error).