Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Changed 'join' to 'joins' in path.md #8527

Closed
wants to merge 1 commit into from
Closed

doc: Changed 'join' to 'joins' in path.md #8527

wants to merge 1 commit into from

Conversation

kalmanh
Copy link
Contributor

@kalmanh kalmanh commented Sep 14, 2016 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Redoing #8522

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. labels Sep 14, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Sep 14, 2016

LGTM. Why did you open a new PR?

@imyller
Copy link
Member

imyller commented Sep 14, 2016

LGTM

@lpinca
Copy link
Member

lpinca commented Sep 14, 2016

Nit: can you please update your commit message and replace 'Changed' with 'change'? Thanks!

jasnell
jasnell approved these changes Sep 15, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

targos
targos approved these changes Sep 15, 2016
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpinca
lpinca approved these changes Sep 18, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpinca pushed a commit that referenced this pull request Sep 18, 2016
@kalmanh @lpinca
doc: fix typo in path doc
db1087c 
PR-URL: #8527
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca
Copy link
Member

lpinca commented Sep 18, 2016 •
edited
Loading

Landed in db1087c.

@lpinca lpinca closed this Sep 18, 2016
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@kalmanh @Fishrock123
doc: fix typo in path doc
a91050c 
PR-URL: #8527
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kalmanh @cjihrig @imyller @lpinca @jasnell @targos @MylesBorins @nodejs-github-bot