test: cleanup test-c-ares.js #8577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sejoker I read your file changes and was wondering why did you wrapped callbacks into |
|
@MichaelTSS according to best practices from |
mscdex
added
the
cares
|
LGTM with a comment. |
cjihrig
reviewed
Sep 17, 2016
| @@ -36,8 +36,8 @@ assert.throws(function() { | |||
| // C:\Windows\System32\drivers\etc\hosts | |||
| // so we disable this test on Windows. | |||
| if (!common.isWindows) { | |||
| dns.reverse('127.0.0.1', function(error, domains) { | |||
| dns.reverse('127.0.0.1', common.mustCall(function(error, domains) { | |||
| if (error) throw error; | |||
There was a problem hiding this comment.
Could you change this line to assert.ifError(error);.
There was a problem hiding this comment.
@cjihrig updated PR according to feedback.
replace equal with strictEqual, use const instead of var replace throw error with assert.ifError
sejoker
force-pushed
the
tests-cleanup-strict-equal
branch
from
1258850 to
012e80a
Compare
imyller
changed the title
|
I'll start the process of landing this. Will amend the commit title to: |
imyller
pushed a commit
that referenced
this pull request
Sep 19, 2016
Replace equal with strictEqual, use const instead of var Replace throw error with assert.ifError PR-URL: #8577 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Replace equal with strictEqual, use const instead of var Replace throw error with assert.ifError PR-URL: #8577 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup according to nodejs/code-and-learn#56
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change