internal: changed var to const in bootstrap_node.js #8588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
lib / src
|
LGTM |
Fishrock123
approved these changes
Sep 17, 2016
There was a problem hiding this comment.
Seems fine to me, CI for good measure: https://ci.nodejs.org/job/node-test-pull-request/4088/
jasnell
pushed a commit
that referenced
this pull request
Sep 20, 2016
PR-URL: #8588 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Landed in 41a66bc. I did fix up the commit message a minor bit |
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
PR-URL: #8588 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
internalsDescription of change
Changed
vartoconstwhere needed. Left the ones that can belet. @thealphanerd pointed out that it is not used in "core" code.Part of nodejs/code-and-learn#56