test: cleanup test-cluster-disconnect-unshared-tcp #8598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RachBLondon May I kindly ask you to reference specific test in the commit message? Thank you. |
imyller
approved these changes
Sep 20, 2016
|
@RachBLondon no worries. I'll start landing this and will fix the commit title. |
imyller
changed the title
|
linux-ppc test actually succeeded, the just status did not correctly update to GitHub. |
|
We've got three LGTMs, CI green and no objections. Landing. |
imyller
pushed a commit
that referenced
this pull request
Sep 20, 2016
Replaced var with const PR-URL: #8598 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
landed in 0f7fffb Thank you for your contribution, @RachBLondon |
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Replaced var with const PR-URL: #8598 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
test/parallel/test-cluster-disconnect-unshared-tcp.jsvarwithconst.