test:parallel: cleanup test-child-process-exec-env #8600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
child_process
addaleax
approved these changes
Sep 17, 2016
| } else { | ||
| success_count++; | ||
| assert.equal(true, stdout != ''); | ||
| assert.strictEqual(true, stdout != ''); |
There was a problem hiding this comment.
This might also be just assert.notStrictEqual(stdout, '');?
There was a problem hiding this comment.
@addaleax updated PR with assert.notStrictEqual
replace equal with strictEqual, use const instead of var, improve test with use of assert.notStrictEqual
sejoker
force-pushed
the
test-child-process-exec-env-cleanup
branch
from
9aa994d to
b69f522
Compare
|
I'll start landing this:
|
imyller
pushed a commit
to imyller/node
that referenced
this pull request
Sep 20, 2016
Replace equal with strictEqual, use const instead of var and improve test with use of assert.notStrictEqual PR-URL: nodejs#8600 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Replace equal with strictEqual, use const instead of var and improve test with use of assert.notStrictEqual PR-URL: #8600 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup according to nodejs/code-and-learn#56
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
replace equal with strictEqual, use const instead of var