Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: changed var to const in internal/process.js #8614

Closed
wants to merge 1 commit into from
Closed

process: changed var to const in internal/process.js #8614

wants to merge 1 commit into from

Conversation

AdriVanHoudt
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Sep 17, 2016 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

process

Description of change

Changed var to const.
Part of nodejs/code-and-learn#56

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Sep 17, 2016
cjihrig
cjihrig approved these changes Sep 17, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although perhaps the commit subsystem should be process.

@AdriVanHoudt
Copy link
Contributor Author

@cjihrig yeah not super familiar with the subsystems so let me know if it needs changing

@AdriVanHoudt
Copy link
Contributor Author

@addaleax should I also change this to process?

@jasnell
Copy link
Member

jasnell commented Sep 20, 2016 •
edited
Loading

Yes, please make the prefix process: (I'm not @addaleax obviously but still.. ;-) ....)

@jasnell
Copy link
Member

jasnell commented Sep 20, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4162/

jasnell
jasnell approved these changes Sep 20, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdriVanHoudt AdriVanHoudt changed the title internal: changed var to const in internal/process.js process: changed var to const in internal/process.js Sep 20, 2016
@AdriVanHoudt
Copy link
Contributor Author

@jasnell I think I broke the CI link by force pushing 😅

@jasnell
Copy link
Member

jasnell commented Sep 20, 2016

it should be fine... I hope ;-) ... will check it out shortly.

imyller
imyller approved these changes Sep 22, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imyller imyller self-assigned this Sep 22, 2016
@imyller
Copy link
Member

imyller commented Sep 22, 2016

New CI: https://ci.nodejs.org/job/node-test-pull-request/4229/

@imyller
Copy link
Member

imyller commented Sep 22, 2016

I'll start landing this:

  • Three LGTMs
  • No objections
  • Requested modifications have been made
  • CI tests passed (only known CI failures; unrelated to this PR)

imyller pushed a commit to imyller/node that referenced this pull request Sep 23, 2016
@AdriVanHoudt @imyller
process: changed var to const in internal/process.js
ba763e7 
PR-URL: nodejs#8614
Refs: nodejs/code-and-learn#56
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@imyller
Copy link
Member

imyller commented Sep 23, 2016

landed in ba763e7

Thank you for your contribution, @AdriVanHoudt

@imyller imyller closed this Sep 23, 2016
@imyller imyller removed their assignment Sep 23, 2016
@AdriVanHoudt AdriVanHoudt deleted the const_process branch September 23, 2016 09:17
@AdriVanHoudt
Copy link
Contributor Author

No problem!

jasnell pushed a commit that referenced this pull request Sep 29, 2016
@AdriVanHoudt @jasnell
process: changed var to const in internal/process.js
ce65ac1 
PR-URL: #8614
Refs: nodejs/code-and-learn#56
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@AdriVanHoudt @Fishrock123
process: changed var to const in internal/process.js
e0c10f6 
PR-URL: #8614
Refs: nodejs/code-and-learn#56
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@imyller imyller imyller approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AdriVanHoudt @jasnell @imyller @cjihrig @MylesBorins @nodejs-github-bot