Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: vars to const and let in child_process #8617

Closed
wants to merge 1 commit into from
Closed

test: vars to const and let in child_process #8617

wants to merge 1 commit into from

Conversation

DennisSchwartz
Copy link

@DennisSchwartz DennisSchwartz commented Sep 17, 2016 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Replaced var keyword with const and let in some of the tests for child
process stdin and stdio.

As part of nodejs/code-and-learn#56

test: Vars to const and let in child_process
0d343b8 
Replaced var keyword with const and let in the tests for child process
stdin and stdio.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 17, 2016
cjihrig
cjihrig approved these changes Sep 17, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Sep 17, 2016
addaleax
addaleax approved these changes Sep 17, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a green CI run

@imyller
Copy link
Member

imyller commented Sep 17, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4094/

imyller
imyller approved these changes Sep 17, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imyller imyller self-assigned this Sep 19, 2016
imyller pushed a commit that referenced this pull request Sep 19, 2016
@imyller
test: improve child_process tests
366495d 
Replaced var keyword with const and let in the tests for child process
stdin and stdio.

PR-URL: #8617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@imyller
Copy link
Member

imyller commented Sep 19, 2016

landed in 366495d

Thank you @DennisSchwartz, your contribution is much appreciated.

@imyller imyller closed this Sep 19, 2016
@imyller imyller removed their assignment Sep 19, 2016
@imyller imyller mentioned this pull request Sep 20, 2016
Closed
2 tasks
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@Fishrock123
test: improve child_process tests
9c3d521 
Replaced var keyword with const and let in the tests for child process
stdin and stdio.

PR-URL: #8617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@imyller imyller imyller approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DennisSchwartz @imyller @addaleax @cjihrig @mscdex @MylesBorins @nodejs-github-bot