Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: changed var to const in internal/v8_prof_processor #8619

Closed
wants to merge 1 commit into from
Closed

process: changed var to const in internal/v8_prof_processor #8619

wants to merge 1 commit into from

Conversation

AdriVanHoudt
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Sep 17, 2016 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

process

Description of change

Changed var to const.
Part of nodejs/code-and-learn#56

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 17, 2016
cjihrig
cjihrig approved these changes Sep 17, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Sep 17, 2016
imyller
imyller approved these changes Sep 17, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

addaleax
addaleax approved these changes Sep 17, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the commit message should start with process:

@AdriVanHoudt AdriVanHoudt force-pushed the const_v8_prof_processor branch from 132a53a to 3730d2f Compare September 18, 2016 07:43
@AdriVanHoudt
Copy link
Contributor Author

@addaleax changed

@AdriVanHoudt AdriVanHoudt changed the title internal: changed var to const in internal/v8_prof_processor process: changed var to const in internal/v8_prof_processor Sep 18, 2016
@jasnell
Copy link
Member

jasnell commented Sep 20, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4161/

jasnell
jasnell approved these changes Sep 20, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

jasnell pushed a commit that referenced this pull request Sep 22, 2016
@AdriVanHoudt @jasnell
process: changed var to const in internal/v8_prof_processor
3ddc9db 
PR-URL: #8619
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented Sep 22, 2016

Landed in 3ddc9db. Thank you!

@jasnell jasnell closed this Sep 22, 2016
@AdriVanHoudt AdriVanHoudt deleted the const_v8_prof_processor branch September 22, 2016 21:50
@AdriVanHoudt
Copy link
Contributor Author

No problem!

jasnell pushed a commit that referenced this pull request Sep 29, 2016
@AdriVanHoudt @jasnell
process: changed var to const in internal/v8_prof_processor
2c25584 
PR-URL: #8619
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@AdriVanHoudt @Fishrock123
process: changed var to const in internal/v8_prof_processor
37ce6da 
PR-URL: #8619
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@imyller imyller imyller approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@AdriVanHoudt @jasnell @addaleax @imyller @cjihrig @mscdex @MylesBorins @nodejs-github-bot