test: refactored test-crypto-random.js #8632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `var` by `const` for constant variables, enforced strict equality check, and replaced custom callback execution check by `common.mustCall`. Signed-off-by: Tobias Kahse <tobias.kahse@hpe.com>
|
Oh, whoever lands this should remove |
|
@Fishrock123 If removal of /cc @nodejs/documentation |
|
If CI is green, I'll start landing this. |
imyller
pushed a commit
that referenced
this pull request
Sep 19, 2016
Replaced `var` by `const` for constant variables, enforced strict equality check, and replaced custom callback execution check by `common.mustCall`. PR-URL: #8632 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
|
landed in 48142bc Thank you for your contribution, @Thylossus |
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Replaced `var` by `const` for constant variables, enforced strict equality check, and replaced custom callback execution check by `common.mustCall`. PR-URL: #8632 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Test
Description of change
Replaced
varbyconstfor constant variables, enforcedstrict equality check, and replaced custom callback execution
check by
common.mustCall.Part of nodejs/code-and-learn#56
Signed-off-by: Tobias Kahse tobias.kahse@hpe.com