Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: clean up icu/README.md formatting #8660

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Sep 20, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

Clean up icu/README.md formatting:

  1. Normalize headings.
  2. Specify language in all code blocks.

Extracted from #8551 to make that one easier to review.

/cc @Trott, @srl295.

@ChALkeR ChALkeR added tools Issues and PRs related to the tools directory. i18n-api Issues and PRs related to the i18n implementation. labels Sep 20, 2016
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 20, 2016
@Trott
Copy link
Member

Trott commented Sep 20, 2016

LGTM

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

 1. Normalize headings.
 2. Specify language in all code blocks.

PR-URL: nodejs#8660
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ChALkeR ChALkeR merged commit fe69d0d into nodejs:master Sep 20, 2016
@ChALkeR
Copy link
Member Author

ChALkeR commented Sep 20, 2016

Landed in fe69d0d.

Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
 1. Normalize headings.
 2. Specify language in all code blocks.

PR-URL: #8660
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants