doc: standardize on make -j8
#8678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the docs recommend `make -j8`. The one exception is the pull request template which recommends `make -j4`. This changes the pull request template so that it is in line with the other docs.
nodejs-github-bot
added
the
meta
|
LGTM |
targos
approved these changes
Sep 21, 2016
|
LGTM |
jbergstroem
approved these changes
Sep 21, 2016
|
LGTM |
gibfahn
approved these changes
Sep 21, 2016
|
LGTM |
danbev
approved these changes
Sep 22, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 23, 2016
Most of the docs recommend `make -j8`. The one exception is the pull request template which recommends `make -j4`. This changes the pull request template so that it is in line with the other docs. PR-URL: nodejs#8678 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
Landed in adb3ca6 |
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
Most of the docs recommend `make -j8`. The one exception is the pull request template which recommends `make -j4`. This changes the pull request template so that it is in line with the other docs. PR-URL: #8678 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Most of the docs recommend `make -j8`. The one exception is the pull request template which recommends `make -j4`. This changes the pull request template so that it is in line with the other docs. PR-URL: #8678 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Most of the docs recommend
make -j8. The one exception is the pullrequest template which recommends
make -j4. This changes the pullrequest template so that it is in line with the other docs.