test: cleanup vars to const and '==' to '===' #8705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified test-http-upgrade-client.js Line 29: Changed var port to const port Line 30: Changed var headers to const headers Line 57: Changed assert.equal to assert.strictEqual Line 61: Changed var expectedHeaders to const Line 69: Changed '==' to '===' comparison
|
LGTM |
targos
approved these changes
Sep 23, 2016
|
Landing:
|
imyller
pushed a commit
to imyller/node
that referenced
this pull request
Sep 24, 2016
Modified test-http-upgrade-client.js Line 29: Changed var port to const port Line 30: Changed var headers to const headers Line 57: Changed assert.equal to assert.strictEqual Line 61: Changed var expectedHeaders to const Line 69: Changed '==' to '===' comparison PR-URL: nodejs#8705 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
Modified test-http-upgrade-client.js Line 29: Changed var port to const port Line 30: Changed var headers to const headers Line 57: Changed assert.equal to assert.strictEqual Line 61: Changed var expectedHeaders to const Line 69: Changed '==' to '===' comparison PR-URL: #8705 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
geek
pushed a commit
to geek/node
that referenced
this pull request
Sep 30, 2016
Modified test-http-upgrade-client.js Line 29: Changed var port to const port Line 30: Changed var headers to const headers Line 57: Changed assert.equal to assert.strictEqual Line 61: Changed var expectedHeaders to const Line 69: Changed '==' to '===' comparison PR-URL: nodejs#8705 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Modified test-http-upgrade-client.js Line 29: Changed var port to const port Line 30: Changed var headers to const headers Line 57: Changed assert.equal to assert.strictEqual Line 61: Changed var expectedHeaders to const Line 69: Changed '==' to '===' comparison PR-URL: #8705 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test/parallel
Description of change
Modified test-http-upgrade-client.js to clean up var usage and
equality comparisons to strict equality comparisons.
Line 29: Changed var port to const port
Line 30: Changed var headers to const headers
Line 57: Changed assert.equal to assert.strictEqual
Line 61: Changed var expectedHeaders to const
Line 69: Changed '==' to '===' comparison