doc: enable no-file-name-articles remark-lint rule and rename doc/topics/the-event-loop-timers-and-nexttick.md #8713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
added
doc
ChALkeR
changed the title
ChALkeR
force-pushed
the
no-file-name-articles
branch
from
faaaee7 to
d4f2d5b
Compare
ChALkeR
changed the title
Could you change the references to that |
|
LGTM. Side question. Was that file published somewhere on our website? |
This renames doc/topics/the-event-loop-timers-and-nexttick.md to doc/topics/event-loop-timers-and-nexttick.md, which looks like a better name for that file and enables no-file-name-articles remark-lint rule to prevent such names in the future. PR-URL: nodejs#8713
ChALkeR
force-pushed
the
no-file-name-articles
branch
from
d4f2d5b to
5fc9f35
Compare
|
@addaleax Argh, totally missed that, thanks! |
Doesn't look like it. https://nodejs.org/api/timers.html#timers_setimmediate_callback_arg links directly to the GitHub repo. See also https://google.com/search?q=inurl:the-event-loop-timers-and-nexttick — those all are inside the repo. |
bnoordhuis
approved these changes
Sep 23, 2016
I just filed remarkjs/remark-lint#100 😉. |
jasnell
pushed a commit
that referenced
this pull request
Sep 27, 2016
This renames doc/topics/the-event-loop-timers-and-nexttick.md to doc/topics/event-loop-timers-and-nexttick.md, which looks like a better name for that file and enables no-file-name-articles remark-lint rule to prevent such names in the future. PR-URL: #8713 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in bedc6b6 |
jasnell
pushed a commit
that referenced
this pull request
Sep 29, 2016
This renames doc/topics/the-event-loop-timers-and-nexttick.md to doc/topics/event-loop-timers-and-nexttick.md, which looks like a better name for that file and enables no-file-name-articles remark-lint rule to prevent such names in the future. PR-URL: #8713 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
This renames doc/topics/the-event-loop-timers-and-nexttick.md to doc/topics/event-loop-timers-and-nexttick.md, which looks like a better name for that file and enables no-file-name-articles remark-lint rule to prevent such names in the future. PR-URL: #8713 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
doc, tools
Description of change
This renames
doc/topics/the-event-loop-timers-and-nexttick.mdtodoc/topics/event-loop-timers-and-nexttick.md, which looks like a better name for that file and enablesno-file-name-articlesremark-lint rule to prevent such names in the future.This change is likely controversial because it breaks direct links to that file in the repository, so I made a stand-alone PR for it to be reviewed separately.
That file was merged this April in #4936.
/cc @techjeffharris, @nodejs/documentation, @Trott, @addaleax, @nodejs/collaborators.