buffer: fix check of buffer and rearrange conditional #8739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isSharedArrayBuffer in fromObject was missing obj.buffer moved the 'length' in obj check so that it is checked first making the code slightly more performant and able to handle SharedArrayBuffer without relying on an explicit check.
nodejs-github-bot
added
the
buffer
|
Can you try adding an analogue of assert.doesNotThrow(() => Buffer.from({ buffer: arrayBuf }));line to LGTM with that |
ensure that Buffer.from works when argument is in the from
'{buffer: SharedArrayBuffer}'
trevnorris
reviewed
Sep 23, 2016
| @@ -264,8 +264,8 @@ function fromObject(obj) { | |||
| } | |||
|
|
|||
| if (obj) { | |||
| if (isArrayBuffer(obj.buffer) || 'length' in obj || | |||
| isSharedArrayBuffer(obj)) { | |||
| if ('length' in obj || isArrayBuffer(obj.buffer) || | |||
There was a problem hiding this comment.
here we go. can we not use the in check? very expensive. why not just do another typeof obj.length check?
There was a problem hiding this comment.
That would break hypothetical code which actually explicitly sets obj.length = undefined, right? I would be okay with that, just making sure.
There was a problem hiding this comment.
yes. it would cause this one edge case to throw:
Buffer.from({ 0: 'a', 1: 'b', length: undefined })since this isn't documented or tested i feel like it's a valid minor version change.
There was a problem hiding this comment.
I shall change that sometime today @trevnorris.
There was a problem hiding this comment.
@ojss If it doesn't happen here, don't sweat it. Removing in isn't directly tied to this PR.
|
I’ll start landing this:
|
|
Landed in 2154bc8, thanks for contributing! |
addaleax
pushed a commit
that referenced
this pull request
Oct 6, 2016
isSharedArrayBuffer in fromObject was missing obj.buffer moved the 'length' in obj check so that it is checked first making the code slightly more performant and able to handle SharedArrayBuffer without relying on an explicit check. Ref: #8510 PR-URL: #8739 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell
pushed a commit
that referenced
this pull request
Oct 10, 2016
isSharedArrayBuffer in fromObject was missing obj.buffer moved the 'length' in obj check so that it is checked first making the code slightly more performant and able to handle SharedArrayBuffer without relying on an explicit check. Ref: #8510 PR-URL: #8739 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
isSharedArrayBuffer in fromObject was missing obj.buffer moved the 'length' in obj check so that it is checked first making the code slightly more performant and able to handle SharedArrayBuffer without relying on an explicit check. Ref: #8510 PR-URL: #8739 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
refer to #8510 for more information.
isSharedArrayBuffer in fromObject was missing obj.buffer
moved the 'length' in obj check so that it is checked first making
the code slightly more performant and able to handle SharedArrayBuffer
without relying on an explicit check.
@addaleax please take a look.