Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,tool: add tls.TLSSocket to typeMap #8742

Closed
wants to merge 1 commit into from

Conversation

yorkie
Copy link
Contributor

@yorkie yorkie commented Sep 23, 2016

Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

We use tls.TLSSocket type in tls.md, so that needs to be added to doctool's typeMap.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 23, 2016
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yorkie yorkie force-pushed the doctool/add-tlssocket branch from 41d2ba5 to 5d13120 Compare September 26, 2016 16:27
We use tls.TLSSocket type in tls.md, so that needs to be added to doctool's typeMap

PR-URL: nodejs#8742
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@yorkie yorkie force-pushed the doctool/add-tlssocket branch from 5d13120 to 279c771 Compare September 26, 2016 16:32
yorkie added a commit that referenced this pull request Sep 26, 2016
We use tls.TLSSocket type in tls.md, so that needs to be added to doctool's typeMap

PR-URL: #8742
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@yorkie
Copy link
Contributor Author

yorkie commented Sep 26, 2016

Landed in 8698f69 thank you @lpinca

@yorkie yorkie closed this Sep 26, 2016
@yorkie yorkie deleted the doctool/add-tlssocket branch September 26, 2016 16:40
jasnell pushed a commit that referenced this pull request Sep 29, 2016
We use tls.TLSSocket type in tls.md, so that needs to be added to doctool's typeMap

PR-URL: #8742
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
geek pushed a commit to geek/node that referenced this pull request Sep 30, 2016
We use tls.TLSSocket type in tls.md, so that needs to be added to doctool's typeMap

PR-URL: nodejs#8742
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Revert
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
We use tls.TLSSocket type in tls.md, so that needs to be added to doctool's typeMap

PR-URL: #8742
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants