Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: accept expected AIX result test-stdio-closed #8755

Closed
wants to merge 1 commit into from
Closed

test: accept expected AIX result test-stdio-closed #8755

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 23, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375

/cc @mhdawson @gireeshpunathil @bnoordhuis

@Trott Trott added the test Issues and PRs related to the tests. label Sep 23, 2016
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 23, 2016
jasnell
jasnell approved these changes Sep 23, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Sep 24, 2016
@Trott Trott force-pushed the stdio-aix branch 2 times, most recently from 9d392e5 to f959362 Compare September 24, 2016 01:55
@Trott
test: accept expected AIX result test-stdio-closed
157381c 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: nodejs#8375
@Trott
Copy link
Member Author

Trott commented Sep 24, 2016

Think I have it now. Let's try CI again: https://ci.nodejs.org/job/node-test-pull-request/4253/

@Trott
Copy link
Member Author

Trott commented Sep 24, 2016

Oh, hi there, green AIX CI run. It's been a while.

@gibfahn
Copy link
Member

gibfahn commented Sep 24, 2016

LGTM

imyller
imyller approved these changes Sep 24, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell pushed a commit that referenced this pull request Sep 26, 2016
@Trott @jasnell
test: accept expected AIX result test-stdio-closed
e65a2d7 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375
PR-URL: #8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@jasnell
Copy link
Member

jasnell commented Sep 26, 2016

Landed in e65a2d7. Thank you!

@jasnell jasnell closed this Sep 26, 2016
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
@Trott
test: accept expected AIX result test-stdio-closed
1420537 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375
PR-URL: #8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
jasnell pushed a commit that referenced this pull request Sep 29, 2016
@Trott @jasnell
test: accept expected AIX result test-stdio-closed
b397c16 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375
PR-URL: #8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
geek pushed a commit to geek/node that referenced this pull request Sep 30, 2016
@Trott @geek
test: accept expected AIX result test-stdio-closed
2a95704 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: nodejs#8375
PR-URL: nodejs#8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@Trott @Fishrock123
test: accept expected AIX result test-stdio-closed
5e4d898 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375
PR-URL: #8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>

 Conflicts:
	test/parallel/parallel.status
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@Trott @rvagg
test: accept expected AIX result test-stdio-closed
47ada06 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375
PR-URL: #8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@Trott @MylesBorins
test: accept expected AIX result test-stdio-closed
b64828d 
AIX handles closed stdio differently (but still compliant with spec as
far as I can tell) than other POSIX variants we test. Test results are
different than Linux and others because AIX takes measures to not re-use
the file descriptors for stdio if one of the stdio streams is closed.

Fixes: #8375
PR-URL: #8755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
@Trott Trott deleted the stdio-aix branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@imyller imyller imyller approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIX: parallel/test-stdio-closed
8 participants
@Trott @gibfahn @jasnell @imyller @mscdex @MylesBorins @mhdawson @nodejs-github-bot