Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add and assert readable/writable arguments #8815

Closed
wants to merge 3 commits into from
+14 −16
Closed

test: add and assert readable/writable arguments #8815

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d74b01
test: add and assert readable/writable arguments
danbev Sep 27, 2016
b9d5d7d
use strictEqual instead of equals
danbev Sep 28, 2016
f16e253
remove console.log statements
danbev Sep 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions test/parallel/test-tcp-wrap-connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,23 @@ function makeConnection() {

var req = new TCPConnectWrap();
var err = client.connect(req, '127.0.0.1', this.address().port);
assert.equal(err, 0);
assert.strictEqual(err, 0);

req.oncomplete = function(status, client_, req_) {
assert.equal(0, status);
assert.equal(client, client_);
assert.equal(req, req_);
req.oncomplete = function(status, client_, req_, readable, writable) {
assert.strictEqual(0, status);
assert.strictEqual(client, client_);
assert.strictEqual(req, req_);
assert.strictEqual(true, readable);
assert.strictEqual(true, writable);

console.log('connected');
var shutdownReq = new ShutdownWrap();
var err = client.shutdown(shutdownReq);
assert.equal(err, 0);
assert.strictEqual(err, 0);

shutdownReq.oncomplete = function(status, client_, req_) {
console.log('shutdown complete');
assert.equal(0, status);
assert.equal(client, client_);
assert.equal(shutdownReq, req_);
assert.strictEqual(0, status);
assert.strictEqual(client, client_);
assert.strictEqual(shutdownReq, req_);
shutdownCount++;
client.close();
};
Expand All @@ -40,11 +40,9 @@ var endCount = 0;
var shutdownCount = 0;

var server = require('net').Server(function(s) {
console.log('got connection');
connectCount++;
s.resume();
s.on('end', function() {
console.log('got eof');
endCount++;
s.destroy();
server.close();
Expand All @@ -54,7 +52,7 @@ var server = require('net').Server(function(s) {
server.listen(0, makeConnection);

process.on('exit', function() {
assert.equal(1, shutdownCount);
assert.equal(1, connectCount);
assert.equal(1, endCount);
assert.strictEqual(1, shutdownCount);
assert.strictEqual(1, connectCount);
assert.strictEqual(1, endCount);
});