Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inspector in v6.x #8832

Closed

Conversation

MylesBorins
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

inspector

Description of change

This is a backport to v6.x of all outstanding inspector changes that do not rely on a Semver Major change.

/cc @nodejs/v8-inspector

Eugene Ostroukhov and others added 8 commits September 28, 2016 11:50
Should help with nodejs#8034.

PR-URL: nodejs#8528
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
This test executes a simple debug session over the inspector protocol.

PR-URL: nodejs#8429
Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
Ctor has to be added as memset to 0 is no longer an option, since
the structure now has std::vector member.

Attempt at fixing nodejs#8155 (so far I was not able to repro it)

PR-URL: nodejs#8536
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Fixes: nodejs#8426
PR-URL: nodejs#8502
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Removes race condition when test relied on both sides of the socket
to be closed on the same UV event loop iteration.

Fixes: nodejs#8498
PR-URL: nodejs#8505
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-by: Fedor Indutny <fedor@indutny.com>
Embed the compressed and minified protocol.json from the bundled
v8_inspector and make it available through the /json/protocol endpoint.

Refs: nodejs/diagnostics#52
PR-URL: nodejs#7491
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Stress tests uncovered 2 race conditions, when IO events happened during
V8 entering event loop on pause or during Node.js shutdown.

Fixes: nodejs#8669
PR-URL: nodejs#8672
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Remove obsolete build file entries.

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#8753
@MylesBorins MylesBorins added v6.x inspector Issues and PRs related to the V8 inspector protocol labels Sep 28, 2016
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. tools Issues and PRs related to the tools directory. v6.x inspector Issues and PRs related to the V8 inspector protocol zlib Issues and PRs related to the zlib subsystem. labels Sep 28, 2016
@MylesBorins
Copy link
Contributor Author

@MylesBorins
Copy link
Contributor Author

@mscdex mscdex removed build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. zlib Issues and PRs related to the zlib subsystem. labels Sep 28, 2016
@MylesBorins
Copy link
Contributor Author

We will need to include #8835 to stop CI in windows from breaking

PR-URL: nodejs#8835
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor Author

@MylesBorins
Copy link
Contributor Author

/cc @nodejs/platform-solaris can you take a look at the smartos failures here.

@ofrobots
Copy link
Contributor

I have relaunched the smartos build here: https://ci.nodejs.org/job/node-test-commit-smartos/4525/

@ofrobots
Copy link
Contributor

SmartOS jobs are green on the re-run.

@MylesBorins
Copy link
Contributor Author

landed in 4d41bd9...83ed508

@MylesBorins MylesBorins deleted the update-inspector-v6.x branch November 14, 2017 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants