test: use common.skip for tap skip output and test cleanup #8841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `var` to `const`, strings to template literals, and assert.equal to assert.strictEqual where appropriate.
lpinca
approved these changes
Sep 29, 2016
| var filename = path.join(common.tmpDir, '/readfile_pipe_large_test.txt'); | ||
| var dataExpected = new Array(1000000).join('a'); | ||
| const filename = path.join(common.tmpDir, '/readfile_pipe_large_test.txt'); | ||
| const dataExpected = new Array(1000000).join('a'); |
There was a problem hiding this comment.
Nit: how about using 'a'.repeat(1e6 - 1)?
| var filename = path.join(common.tmpDir, '/readfilesync_pipe_large_test.txt'); | ||
| var dataExpected = new Array(1000000).join('a'); | ||
| const filename = path.join(common.tmpDir, '/readfilesync_pipe_large_test.txt'); | ||
| const dataExpected = new Array(1000000).join('a'); |
cjihrig
approved these changes
Sep 29, 2016
Fishrock123
pushed a commit
that referenced
this pull request
Sep 30, 2016
Changed `var` to `const`, strings to template literals, and assert.equal to assert.strictEqual where appropriate. PR-URL: #8841 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Thanks, landed in 5e6bd84...b838e5f! Like @lpinca said, I think cleaning up the functionality may be best saved for another PR. |
|
@jasnell sorry, didn't catch your sign-off in the commits because GitHub hadn't refreshed or something, not worth to force-push imo. :) |
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
Changed `var` to `const`, strings to template literals, and assert.equal to assert.strictEqual where appropriate. PR-URL: #8841 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Changed `var` to `const`, strings to template literals, and assert.equal to assert.strictEqual where appropriate. PR-URL: #8841 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Using
common.skipinstead ofconsole.logfor test output. Updated JS syntax to ES6constand template strings where appropriate.