test: fix running child-process-uid-gid as root #8864
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
LGTM For whoever lands this: This change is identical to the one in #8794 which already received several approvals. |
addaleax
added
the
child_process
|
I'm sorry I didn't see the original PR, but I wonder if it wouldn't be better to change the UID when it's 0 instead of skipping the test ? |
|
I'd prefer either skipping or failing than changing... changing the UID would mask the problem a bit if the test does happen to be run as root (it would pass when under tested conditions it typically would not) |
geek
added a commit
to geek/node
that referenced
this pull request
Oct 3, 2016
This skips the child-test-uid-gid test when run as root. Previously, the test failed if executed as root. PR-URL: nodejs#8864 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
|
CI failures look unrelated. |
geek
added a commit
that referenced
this pull request
Oct 3, 2016
This skips the child-test-uid-gid test when run as root. Previously, the test failed if executed as root. PR-URL: #8864 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
|
Landed in 8dc2b42 |
|
Was there a CI run for this change? This test failed on all Windows configurations on the last daily run, can it be related to this? |
targos
added a commit
that referenced
this pull request
Oct 4, 2016
The process.getuid method does not exist on this platform. Ref: #8864
2 tasks
There was one in the original PR and it apparently failed on Windows. Fix here: #8924 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 4, 2016
The process.getuid method does not exist on this platform. Ref: nodejs#8864 PR-URL: nodejs#8924 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
This skips the child-test-uid-gid test when run as root. Previously, the test failed if executed as root. PR-URL: #8864 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
This skips the child-test-uid-gid test when run as root. Previously, the test failed if executed as root. PR-URL: #8864 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
test-child-process-uid-gid fails when run as root. Seeing that other tests are skipped when running as root, adding the same behavior to this test as well.
Replaces #8794