module: correct comment text "read-only" to "shallow" #8887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment here was misleading, implying that the property was being copied as a read-only, when in fact it's just a shallow copy. This serves the purpose of providing the array for introspection, but it isn't read-only.
nodejs-github-bot
added
the
module
|
LGTM |
targos
approved these changes
Oct 1, 2016
fhinkel
approved these changes
Oct 3, 2016
|
Thanks! Landed in 4c619ec. |
fhinkel
pushed a commit
that referenced
this pull request
Oct 3, 2016
The comment here was misleading, implying that the property was being copied as a read-only, when in fact it's just a shallow copy. This serves the purpose of providing the array for introspection, but it isn't read-only. PR-URL: #8887 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
The comment here was misleading, implying that the property was being copied as a read-only, when in fact it's just a shallow copy. This serves the purpose of providing the array for introspection, but it isn't read-only. PR-URL: #8887 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
The comment here was misleading, implying that the property was being copied as a read-only, when in fact it's just a shallow copy. This serves the purpose of providing the array for introspection, but it isn't read-only. PR-URL: #8887 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
module
Description of change
The comment here was misleading, implying that the property was being
copied as a read-only, when in fact it's just a shallow copy. This
serves the purpose of providing the array for introspection, but it
isn't read-only.