Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-tick-processor-unknown flaky #8900

Closed
wants to merge 1 commit into from
Closed

test: mark test-tick-processor-unknown flaky #8900

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 3, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

@Trott Trott added the test Issues and PRs related to the tests. label Oct 3, 2016
@Trott
Copy link
Member Author

Trott commented Oct 3, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4362/

@mscdex mscdex added process Issues and PRs related to the process subsystem. tools Issues and PRs related to the tools directory. labels Oct 3, 2016
@Trott
Copy link
Member Author

Trott commented Oct 3, 2016

CI is yellow, with the only cause of yellow being the test marked flaky by this PR. So: Woot.

bnoordhuis
bnoordhuis approved these changes Oct 3, 2016
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is the test flaky on all platforms or is it mostly windows+smartos?

@Trott
Copy link
Member Author

Trott commented Oct 3, 2016

Is the test flaky on all platforms or is it mostly windows+smartos?

Mostly those two that I've noticed.

@Trott
Copy link
Member Author

Trott commented Oct 4, 2016

Quick stress test (just 100 runs) across all (or all-ish) platforms to see if it's really flaky nearly everywhere or if it's really just SmartOS and Windows: https://ci.nodejs.org/job/node-stress-single-test/971/

@Trott
Copy link
Member Author

Trott commented Oct 4, 2016

Based on the stress test results, I'll change this to just marking it as flaky on SmartOS.

@Trott
test: mark test-tick-processor-unknown flaky
f3e4a40 
Mark test-tick-processor-unknown flaky on SmartOS.
@Trott
Copy link
Member Author

Trott commented Oct 4, 2016

CI again: https://ci.nodejs.org/job/node-test-pull-request/4384/

@Trott Trott mentioned this pull request Oct 4, 2016
Closed
4 tasks
@Trott
Copy link
Member Author

Trott commented Oct 4, 2016

Argh, here it is failing on Raspberry Pi: https://ci.nodejs.org/job/node-test-binary-arm/4145/RUN_SUBSET=4,label=pi2-raspbian-wheezy/console

not ok 136 parallel/test-tick-processor-builtin
# TIMEOUT

Hoping that might be fixed by #8848 so might leave it as is. SmartOS seems to be The Big One that this test fails a lot on so getting just that in will still be a big win.

Trott added a commit to Trott/io.js that referenced this pull request Oct 4, 2016
@Trott
test: mark test-tick-processor-unknown flaky
d097311 
Mark test-tick-processor-unknown flaky on SmartOS.

PR-URL: nodejs#8900
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@Trott
Copy link
Member Author

Trott commented Oct 4, 2016

Landed in d097311

@Trott Trott closed this Oct 4, 2016
jasnell pushed a commit that referenced this pull request Oct 6, 2016
@Trott @jasnell
test: mark test-tick-processor-unknown flaky
ce1d662 
Mark test-tick-processor-unknown flaky on SmartOS.

PR-URL: #8900
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@Trott @Fishrock123
test: mark test-tick-processor-unknown flaky
52d0424 
Mark test-tick-processor-unknown flaky on SmartOS.

PR-URL: #8900
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

 Conflicts:
	test/parallel/parallel.status
@Trott Trott deleted the argh branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @bnoordhuis @gibfahn @mscdex @MylesBorins