Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4.x backport: test: improve coverage of the util module #8970

Closed
wants to merge 1 commit into from
Closed

v4.x backport: test: improve coverage of the util module #8970

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 7, 2016

v4.x backport of #8633
/cc @thealphanerd

@targos
test: improve coverage of the util module
b0746e7 
Add tests for untested branches and statements.
Change assert.equal to assert.strictEqual for consistency.

PR-URL: nodejs#8633
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@targos targos added util Issues and PRs related to the built-in util module. test Issues and PRs related to the tests. v4.x labels Oct 7, 2016
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v4.x labels Oct 7, 2016
@targos targos mentioned this pull request Oct 7, 2016
Merged
3 tasks
jasnell
jasnell approved these changes Oct 7, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

landed in 3e6445d thanks @targos

@targos targos deleted the backport-8633-v4.x branch June 1, 2017 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @MylesBorins @jasnell @nodejs-github-bot