test: expand test coverage for url.js #8976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Line 309 of lib/url.js is not reachable from test-url because there are no examples which has more than 255 characters in the hostname of the url. I added one example which can reach that line.
Trott
reviewed
Oct 7, 2016
| @@ -1200,6 +1204,17 @@ var formatTests = { | |||
| pathname: '/' | |||
| }, | |||
|
|
|||
| // more than 255 characters in hostname which excesses the limit | |||
| [excessHostnameUrl]: { | |||
There was a problem hiding this comment.
Nit: Maybe get rid of excessHostnameUrl const altogether and change this line to:
[`http://${'a'.repeat(255)}.com/node`]: {| @@ -1200,6 +1204,17 @@ var formatTests = { | |||
| pathname: '/' | |||
| }, | |||
|
|
|||
| // more than 255 characters in hostname which excesses the limit | |||
jasnell
approved these changes
Oct 7, 2016
imyller
approved these changes
Oct 7, 2016
delete excessHostnameUrl and add exceeded hostname url directly.
|
Thank you for the nits. I have updated. |
imyller
reviewed
Oct 7, 2016
| @@ -999,6 +999,7 @@ for (const u in parseTestsWithQueryString) { | |||
|
|
|||
| // some extra formatting tests, just to verify | |||
| // that it'll format slightly wonky content to a valid url. | |||
|
|
|||
There was a problem hiding this comment.
nit: please remove this empty line
There was a problem hiding this comment.
I'm sorry. I forgot to delete.
gibfahn
approved these changes
Oct 8, 2016
|
only flaky failures in CI. Will land this. |
|
|
jasnell
pushed a commit
that referenced
this pull request
Oct 8, 2016
Add url example with more than 255 characters in the hostname of the url. PR-URL: #8976 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Scratch that, botched the commit log message... landed correctly in 7084b9c |
jasnell
pushed a commit
that referenced
this pull request
Oct 10, 2016
Add url example with more than 255 characters in the hostname of the url. PR-URL: #8976 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Add url example with more than 255 characters in the hostname of the url. PR-URL: #8976 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com> Conflicts: test/parallel/test-url.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test url
Description of change
Currently line 309 of lib/url.js is not reachable from test-url because there are no examples which have more than 255 characters in the hostname of the url.
I added one example which can reach that line.