crypto: naming anonymouse functions #8993

solebox · 2016-10-09T17:18:24Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

crypto

Description of change

rename anonymouse functions
Ref: #8913

solebox · 2016-10-09T17:19:18Z

fixes some of it , not the whole thing. as requested in the thread, pull request per module.

addaleax

Generally, this looks fine! Some of the lines need to be wrapped, and there’s a anonymouse typo in the commit message.

addaleax · 2016-10-09T17:44:05Z

lib/crypto.js

  return binding.certVerifySpkac(object);
 };


-Certificate.prototype.exportPublicKey = function(object, encoding) {
+Certificate.prototype.exportPublicKey = function exportPublicKey(object, encoding) {


Could you check that your lines are no longer than 80 characters?

addaleax · 2016-10-09T17:46:02Z

Oh, and if your commit only partially solves a Github issue, it’s better to use use Ref: than to use Fixes:, so that landing the PR doesn’t automatically close the issue.

solebox · 2016-10-09T19:18:39Z

submitted changes

AndreasMadsen · 2016-10-09T21:01:23Z

Are methods on the prototype object actually a problem? In a normal stack trace they will have a full name e.g. Hash.update, even if the function is technically anonymous.

function C() {}
C.prototype.method = function () { throw new Error(''); }
new C().method()

Error
    at C.method (repl:1:42)
    ...

solebox · 2016-10-09T21:18:24Z

@AndreasMadsen when requesting .name i got an empty string.
that was the means of testing offered in the original issue posted.

i assume that mattered to some people when debugging

(check out the repl feedback , its pretty nice to have name set when you're using repl, really helps)

mscdex · 2016-10-09T21:56:43Z

lib/crypto.js

  return binding.certVerifySpkac(object);
 };


-Certificate.prototype.exportPublicKey = function(object, encoding) {
+Certificate.prototype.exportPublicKey = function exportPublicKey(object, 
+        encoding) {


Typically we like to keep the parameters all lined up if on multiple lines. However in the case that a lined up parameter on a new line would exceed the 80 character mark, it would probably be better to just move everything after the = to the next line and indent the entire function definition by 2 spaces.

Ditto for the changes below.

ok ill do that

jasnell

LGTM if CI is green.

targos · 2016-10-10T18:37:24Z

LGTM

thefourtheye

Change looks okay, but commit message could use the following changes

typo should be fixed and
if possible, an imperative verb could be used as the first word. For example, crypto: name anonymous functions

jasnell · 2016-10-11T17:07:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/4459/

solebox · 2016-10-12T13:28:02Z

@jasnell hello james , my commit only changes javascript i dont see a reason why it wont work on all platforms just the same.

looks like test-npm-install.js is the culprit (at least in the free-bsd box, arm has no report yet)
doesnt look like it has something to do with my changes
am i missing something here?

gibfahn · 2016-10-12T14:22:25Z

@soleboxy Those failures look like infrastructure issues.

gibfahn · 2016-10-12T14:32:49Z

New CI (we'll run it until it works ) https://ci.nodejs.org/job/node-test-pull-request/4490/

lpinca

LGTM

Ref: nodejs#8913 PR-URL: nodejs#8993

addaleax

LGTM

addaleax · 2016-10-15T18:37:14Z

CI: https://ci.nodejs.org/job/node-test-commit/5626/

addaleax · 2016-10-15T19:04:42Z

I’ll start landing this:

Approvals (LGTM): 5
No objections
The PR has been open for the minimum time of 48 or 72 hours
All of the requested changes have been made
CI has only unrelated failures

addaleax · 2016-10-15T19:06:25Z

You author name in this commit is given as “solebox”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you.

addaleax · 2016-10-15T19:25:55Z

Landed in 6f05de4! 🎉

Ref: #8913 PR-URL: #8993 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

MylesBorins · 2016-11-11T20:24:04Z

I'm going to hold off on backporting this at the moment, but I'm very curious where we landed on this and thoughts on backporting to v6

sam-github · 2017-07-25T15:59:19Z

I think we should land it, it looks very safe, its baked for a while, and not having landed caused #11705 to not cherry-pick clean, triggering a backport, #14376.

solebox · 2017-07-27T14:40:19Z

thanks :)

sam-github · 2017-09-20T18:38:06Z

@MylesBorins I pushed this onto v6.x-staging, it cherry picks clean, and will help @tniessen with #14376 which we asked for.

Landed in e9235e8e2efb0443d0d770a7bdce4aff983fdbc9 for v6.x-staging.

Ref: #8913 PR-URL: #8993

nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label Oct 9, 2016

addaleax requested changes Oct 9, 2016

View reviewed changes

solebox force-pushed the rename_functions branch from 52568e7 to 975ee51 Compare October 9, 2016 18:39

mscdex reviewed Oct 9, 2016

View reviewed changes

solebox force-pushed the rename_functions branch from 975ee51 to 707f6c3 Compare October 9, 2016 22:42

jasnell approved these changes Oct 10, 2016

View reviewed changes

thefourtheye approved these changes Oct 11, 2016

View reviewed changes

lpinca approved these changes Oct 12, 2016

View reviewed changes

crypto: naming anonymous functions.

72be5ed

Ref: nodejs#8913 PR-URL: nodejs#8993

solebox force-pushed the rename_functions branch from 707f6c3 to 72be5ed Compare October 13, 2016 22:31

addaleax approved these changes Oct 15, 2016

View reviewed changes

addaleax self-assigned this Oct 15, 2016

addaleax closed this Oct 15, 2016

MylesBorins added dont-land-on-v4.x labels Nov 11, 2016

MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 9, 2017

gibfahn mentioned this pull request Jun 15, 2017

Auditing for 6.11.1 nodejs/Release#230

Closed

3 tasks

sam-github mentioned this pull request Jul 25, 2017

[v6.x backport] crypto: add sign/verify support for RSASSA-PSS #14376

Closed

4 tasks

sam-github added the lts-agenda label Jul 25, 2017

MylesBorins pushed a commit that referenced this pull request Sep 20, 2017

crypto: naming anonymous functions.

25be2a3

Ref: #8913 PR-URL: #8993

MylesBorins mentioned this pull request Sep 20, 2017

v6.11.4 proposal #15506

Merged

MylesBorins removed lts-agenda labels Nov 14, 2017

MylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

crypto: naming anonymouse functions #8993

crypto: naming anonymouse functions #8993

solebox commented Oct 9, 2016 •

edited by Fishrock123

Loading

solebox commented Oct 9, 2016

addaleax left a comment

addaleax Oct 9, 2016

solebox Oct 10, 2016

addaleax commented Oct 9, 2016

solebox commented Oct 9, 2016

AndreasMadsen commented Oct 9, 2016 •

edited

Loading

solebox commented Oct 9, 2016 •

edited

Loading

mscdex Oct 9, 2016

solebox Oct 9, 2016

solebox Oct 9, 2016

jasnell left a comment

targos commented Oct 10, 2016

thefourtheye left a comment

jasnell commented Oct 11, 2016

solebox commented Oct 12, 2016

gibfahn commented Oct 12, 2016

gibfahn commented Oct 12, 2016

lpinca left a comment

addaleax left a comment

addaleax commented Oct 15, 2016

addaleax commented Oct 15, 2016

addaleax commented Oct 15, 2016

addaleax commented Oct 15, 2016

MylesBorins commented Nov 11, 2016

sam-github commented Jul 25, 2017

solebox commented Jul 27, 2017

sam-github commented Sep 20, 2017

crypto: naming anonymouse functions #8993

crypto: naming anonymouse functions #8993

Conversation

solebox commented Oct 9, 2016 • edited by Fishrock123 Loading

Checklist

Affected core subsystem(s)

Description of change

solebox commented Oct 9, 2016

addaleax left a comment

Choose a reason for hiding this comment

addaleax Oct 9, 2016

Choose a reason for hiding this comment

solebox Oct 10, 2016

Choose a reason for hiding this comment

addaleax commented Oct 9, 2016

solebox commented Oct 9, 2016

AndreasMadsen commented Oct 9, 2016 • edited Loading

solebox commented Oct 9, 2016 • edited Loading

mscdex Oct 9, 2016

Choose a reason for hiding this comment

solebox Oct 9, 2016

Choose a reason for hiding this comment

solebox Oct 9, 2016

Choose a reason for hiding this comment

jasnell left a comment

Choose a reason for hiding this comment

targos commented Oct 10, 2016

thefourtheye left a comment

Choose a reason for hiding this comment

jasnell commented Oct 11, 2016

solebox commented Oct 12, 2016

gibfahn commented Oct 12, 2016

gibfahn commented Oct 12, 2016

lpinca left a comment

Choose a reason for hiding this comment

addaleax left a comment

Choose a reason for hiding this comment

addaleax commented Oct 15, 2016

addaleax commented Oct 15, 2016

addaleax commented Oct 15, 2016

addaleax commented Oct 15, 2016

MylesBorins commented Nov 11, 2016

sam-github commented Jul 25, 2017

solebox commented Jul 27, 2017

sam-github commented Sep 20, 2017

solebox commented Oct 9, 2016 •

edited by Fishrock123

Loading

AndreasMadsen commented Oct 9, 2016 •

edited

Loading

solebox commented Oct 9, 2016 •

edited

Loading