Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: fix request path nullptr dereference #9184

Merged
merged 2 commits into from
Oct 24, 2016
Merged

inspector: fix request path nullptr dereference #9184

merged 2 commits into from
Oct 24, 2016

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Oct 19, 2016 •
edited
Loading

@bnoordhuis bnoordhuis added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol labels Oct 19, 2016
cjihrig
cjihrig approved these changes Oct 19, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace the if (err) throw err; in the tests with assert.ifError(err);. Other than that, LGTM.

jasnell
jasnell approved these changes Oct 19, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ofrobots
ofrobots approved these changes Oct 19, 2016
View reviewed changes
Copy link
Contributor

@ofrobots ofrobots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bnoordhuis bnoordhuis mentioned this pull request Oct 22, 2016
Closed
2 tasks
@bnoordhuis bnoordhuis force-pushed the fix-inspector-nullptr branch from a611bf9 to d3e654e Compare October 24, 2016 18:35
@bnoordhuis
Copy link
Member Author

bnoordhuis commented Oct 24, 2016 •
edited
Loading

Rebased and merge conflict fixed. New run: https://ci.nodejs.org/job/node-test-pull-request/4647/

EDIT: https://ci.nodejs.org/job/node-test-pull-request/4650/

@bnoordhuis bnoordhuis force-pushed the fix-inspector-nullptr branch from d3e654e to 7c933a7 Compare October 24, 2016 20:28
@bnoordhuis
Copy link
Member Author

Flakes on a freebsd and smartos buildbot, an infrastructure issue on one of the rpi1 machines. Nothing that is caused by this pull request so I'll go ahead and land it.

@bnoordhuis
inspector: fix request path nullptr dereference
3d9b379 
Fix a nullptr dereference when an invalid path is requested.

Regression introduced in commit 69fc85d ("inspector: generate UUID for
debug targets"), caught by Coverity.

PR-URL: nodejs#9184
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis
test: remove test-v8-inspector-json-protocol test
8e54c96 
Remove parallel/test-v8-inspector-json-protocol, it duplicates the test
found in inspector/test-inspector.

PR-URL: nodejs#9184
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis bnoordhuis force-pushed the fix-inspector-nullptr branch from 7c933a7 to 8e54c96 Compare October 24, 2016 21:08
@bnoordhuis bnoordhuis closed this Oct 24, 2016
@bnoordhuis bnoordhuis deleted the fix-inspector-nullptr branch October 24, 2016 21:08
@bnoordhuis bnoordhuis merged commit 8e54c96 into nodejs:master Oct 24, 2016
evanlucas pushed a commit that referenced this pull request Nov 2, 2016
@bnoordhuis @evanlucas
inspector: fix request path nullptr dereference
2e7b078 
Fix a nullptr dereference when an invalid path is requested.

Regression introduced in commit 69fc85d ("inspector: generate UUID for
debug targets"), caught by Coverity.

PR-URL: #9184
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Nov 2, 2016
@bnoordhuis @evanlucas
test: remove test-v8-inspector-json-protocol test
06b4140 
Remove parallel/test-v8-inspector-json-protocol, it duplicates the test
found in inspector/test-inspector.

PR-URL: #9184
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
@bnoordhuis
inspector: fix request path nullptr dereference
6f68a14 
Fix a nullptr dereference when an invalid path is requested.

Regression introduced in commit 69fc85d ("inspector: generate UUID for
debug targets"), caught by Coverity.

PR-URL: #9184
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
@bnoordhuis
test: remove test-v8-inspector-json-protocol test
ca335f7 
Remove parallel/test-v8-inspector-json-protocol, it duplicates the test
found in inspector/test-inspector.

PR-URL: #9184
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
@bnoordhuis @MylesBorins
inspector: fix request path nullptr dereference
b5bcd25 
Fix a nullptr dereference when an invalid path is requested.

Regression introduced in commit 69fc85d ("inspector: generate UUID for
debug targets"), caught by Coverity.

PR-URL: #9184
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
@bnoordhuis @MylesBorins
test: remove test-v8-inspector-json-protocol test
ef1cf6b 
Remove parallel/test-v8-inspector-json-protocol, it duplicates the test
found in inspector/test-inspector.

PR-URL: #9184
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@eugeneo eugeneo eugeneo approved these changes

@ofrobots ofrobots ofrobots approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bnoordhuis @ofrobots @eugeneo @jasnell @cjihrig @MylesBorins