test: remove timer in test-dgram-send-empty-array #9361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
dgram
The timer is not necessary. The test will timeout via the test harness if the test fails. This should resolve spurious CI failures.
|
GREEN! CI IS GREEN! |
santigimeno
approved these changes
Oct 30, 2016
cjihrig
approved these changes
Oct 30, 2016
jasnell
approved these changes
Oct 30, 2016
evanlucas
approved these changes
Nov 1, 2016
lpinca
approved these changes
Nov 1, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 2, 2016
The timer is not necessary. The test will timeout via the test harness if the test fails. This should resolve spurious CI failures. PR-URL: nodejs#9361 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 968fc72 |
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
The timer is not necessary. The test will timeout via the test harness if the test fails. This should resolve spurious CI failures. PR-URL: #9361 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
The timer is not necessary. The test will timeout via the test harness if the test fails. This should resolve spurious CI failures. PR-URL: #9361 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test dgram
Description of change
The timer is not necessary. The test will timeout via the test harness
if the test fails. This should resolve spurious CI failures.