Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix e.g., to e.g. in doc/http.md #9564

Closed
wants to merge 1 commit into from
Closed

doc: fix e.g., to e.g. in doc/http.md #9564

wants to merge 1 commit into from
+2 −2

Conversation

ikasumiwt
Copy link
Contributor

@ikasumiwt ikasumiwt commented Nov 12, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

fix e.g., to e.g. in doc/http.md

Fixes: nodejs/code-and-learn#58

@ikasumiwt
doc: fix e.g., to e.g. in doc/http.md
e102734 
fix e.g., to e.g. in doc/http.md

Fixes: nodejs/code-and-learn#58
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Nov 12, 2016
@yosuke-furukawa
Copy link
Member

LGTM, but you need to check commit message follows commit guidelines.

addaleax
addaleax approved these changes Nov 12, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shigeki pushed a commit that referenced this pull request Nov 13, 2016
@ikasumiwt @shigeki
doc: fix e.g., to e.g. in doc/http.md
7030f09 
fix e.g., to e.g. in doc/http.md

Fixes: nodejs/code-and-learn#58
PR-URL: #9564
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@shigeki
Copy link
Contributor

shigeki commented Nov 13, 2016

Thanks. Landed in 7030f09.
Congrats on your first contribution to Node.

@shigeki shigeki closed this Nov 13, 2016
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@ikasumiwt @addaleax
doc: fix e.g., to e.g. in doc/http.md
64dec14 
fix e.g., to e.g. in doc/http.md

Fixes: nodejs/code-and-learn#58
PR-URL: #9564
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
@ikasumiwt @MylesBorins
doc: fix e.g., to e.g. in doc/http.md
229fa69 
fix e.g., to e.g. in doc/http.md

Fixes: nodejs/code-and-learn#58
PR-URL: #9564
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
@ikasumiwt @MylesBorins
doc: fix e.g., to e.g. in doc/http.md
9709331 
fix e.g., to e.g. in doc/http.md

Fixes: nodejs/code-and-learn#58
PR-URL: #9564
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@ikasumiwt @MylesBorins
doc: fix e.g., to e.g. in doc/http.md
51b5592 
fix e.g., to e.g. in doc/http.md

Fixes: nodejs/code-and-learn#58
PR-URL: #9564
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@ikasumiwt @MylesBorins
doc: fix e.g., to e.g. in doc/http.md
26ee3fc 
fix e.g., to e.g. in doc/http.md

Fixes: nodejs/code-and-learn#58
PR-URL: #9564
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@shigeki shigeki shigeki approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code And Learn at NodeFest 2016
8 participants
@ikasumiwt @yosuke-furukawa @shigeki @silverwind @addaleax @lpinca @MylesBorins @nodejs-github-bot