Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in doc/repl.md line: 6 #9582

Closed
wants to merge 1 commit into from

Conversation

utano320
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

fix doc/api/repl.md line 6 "includable" => "inclidable"

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem. labels Nov 12, 2016
@yosuke-furukawa
Copy link
Member

Ooops, you introduce other typo... includible is correct word?

@utano320 utano320 force-pushed the fix-speling-error-doc-repl branch from edacdb0 to a914515 Compare November 12, 2016 10:27
@utano320
Copy link
Contributor Author

Oh, I'm sorry! I fixed it again ...

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shigeki
Copy link
Contributor

shigeki commented Nov 13, 2016

@utano320 I would like to confirm if your git name is correctly set before landing. If you want to prefer to using your real name such as your profile in github, please change it. And when you change the commit name, please squash two commits into one.

@lpinca
Copy link
Member

lpinca commented Nov 13, 2016

I'm not a native speaker but I think "includable" is also correct.

fix doc/api/repl.md line 6 "includable" => "includible"
@utano320 utano320 force-pushed the fix-speling-error-doc-repl branch from a914515 to 58f69e5 Compare November 14, 2016 09:55
@utano320
Copy link
Contributor Author

@shigeki I changed the names of Author and Committer to real names and squashed the two commits to one.

@lpinca Thanks! It certainly seems like that... "includable" was described as "Alternative form of includible" in dictionary.

@shigeki
Copy link
Contributor

shigeki commented Nov 18, 2016

Thanks. Landed in 30bf123.
Congrats on your first contribution to Node.

@shigeki shigeki closed this Nov 18, 2016
shigeki pushed a commit that referenced this pull request Nov 18, 2016
fix doc/api/repl.md line 6 "includable" => "includible"

Fixes: nodejs/code-and-learn#58
PR-URL: #9582
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
addaleax pushed a commit that referenced this pull request Nov 22, 2016
fix doc/api/repl.md line 6 "includable" => "includible"

Fixes: nodejs/code-and-learn#58
PR-URL: #9582
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
fix doc/api/repl.md line 6 "includable" => "includible"

Fixes: nodejs/code-and-learn#58
PR-URL: #9582
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
fix doc/api/repl.md line 6 "includable" => "includible"

Fixes: nodejs/code-and-learn#58
PR-URL: #9582
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants