doc: small improvements in readline code examples #9628
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Consistent template literals in `console.log()`. 2. === instead of ==.
nodejs-github-bot
added
doc
const instead of var
cjihrig
approved these changes
Nov 16, 2016
|
LGTM |
gonenduk
approved these changes
Nov 17, 2016
jasnell
approved these changes
Nov 18, 2016
targos
approved these changes
Nov 19, 2016
targos
pushed a commit
to targos/node
that referenced
this pull request
Nov 19, 2016
1. Consistent template literals in `console.log()`. 2. === instead of ==. 3. const instead of var. PR-URL: nodejs#9628 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
|
Landed in 4527994. Thanks! |
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
1. Consistent template literals in `console.log()`. 2. === instead of ==. 3. const instead of var. PR-URL: #9628 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
1. Consistent template literals in `console.log()`. 2. === instead of ==. 3. const instead of var. PR-URL: #9628 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
1. Consistent template literals in `console.log()`. 2. === instead of ==. 3. const instead of var. PR-URL: #9628 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Consistent template literals in
console.log().=== instead of ==.
const instead of var.
I am not sure about these two fragments:
In the Use of the completer Function
a. Should it be
(c) => c.indexOf(line) == 0or is this a case ofno-confusing-arroweslint rule?b. Should a semicolon be added after
0if the current variant remains?In the readline.emitKeypressEvents(stream[, interface])
Should it be in one line (like the similar fragment in the Event: 'SIGINT')?
If these ones should be somehow addressed, please, let me know.