Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update require exceptions #9882

Closed
wants to merge 1 commit into from
Closed

test: update require exceptions #9882

wants to merge 1 commit into from

Conversation

ooHmartY
Copy link
Contributor

@ooHmartY ooHmartY commented Dec 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • change var to const
  • check error messages in assert.throws

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the module Issues and PRs related to the module subsystem. label Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 1, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5057/

lpinca
lpinca reviewed Dec 2, 2016
View reviewed changes
test/parallel/test-require-exceptions.js

// A module with an error in it should throw
assert.throws(function() {
require(common.fixturesDir + '/throws_error');
});
}, /blah/);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you please add ^ and $ respectively at the beginning and the end of the regex?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regex has been updated.

test: update require exceptions
94a5696 
Updated regex for error assertion
targos
targos approved these changes Dec 3, 2016
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI: https://ci.nodejs.org/job/node-test-pull-request/5146/

jasnell
jasnell approved these changes Dec 3, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Dec 5, 2016

CI failures are unrelated.

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 5, 2016
@Trott
test: refactor test-require-exceptions
60cc405 
Updated regex for error assertion.

PR-URL: nodejs#9882
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 5, 2016
@Trott
Copy link
Member

Trott commented Dec 5, 2016

Landed in 60cc405.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 5, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
@Fishrock123
test: refactor test-require-exceptions
6502427 
Updated regex for error assertion.

PR-URL: #9882
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@addaleax
test: refactor test-require-exceptions
af5c4a9 
Updated regex for error assertion.

PR-URL: nodejs#9882
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
test: refactor test-require-exceptions
55c6b3f 
Updated regex for error assertion.

PR-URL: nodejs#9882
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@MylesBorins
test: refactor test-require-exceptions
89feb8d 
Updated regex for error assertion.

PR-URL: #9882
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
test: refactor test-require-exceptions
c14a094 
Updated regex for error assertion.

PR-URL: #9882
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@MylesBorins
test: refactor test-require-exceptions
61faf23 
Updated regex for error assertion.

PR-URL: #9882
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ooHmartY @Trott @jasnell @lpinca @targos @cjihrig @mscdex @MylesBorins @addaleax @nodejs-github-bot