test: added validation regex argument to test #9918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this change, I've added the regex pattern to the assert.throws() in order to provide the validation argument for the call.
|
This was made at the NINA Code and Learn session. |
imyller
added
the
code-and-learn
not-an-aardvark
approved these changes
Dec 1, 2016
cjihrig
requested changes
Dec 4, 2016
| @@ -46,7 +46,7 @@ file | |||
| assert.throws(function() { | |||
| console.error('write after end should not be allowed'); | |||
| file.write('should not work anymore'); | |||
| }); | |||
| }, /write/); | |||
There was a problem hiding this comment.
Can a more substantial match be used here?
|
Ping @knarfishness: Can you address @cjihrig's comment? It would be great if the match could be more than one word. Probably this would be best: |
|
Ping @cjihrig: It appears that this has been updated to address your comment. Can you please take a look and, as appropriate update your review? |
cjihrig
approved these changes
Dec 22, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 23, 2016
In this change, I've added the regex pattern to the assert.throws() in order to provide the validation argument for the call. PR-URL: nodejs#9918 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 4e1b2e7. |
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
In this change, I've added the regex pattern to the assert.throws() in order to provide the validation argument for the call. PR-URL: #9918 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
In this change, I've added the regex pattern to the assert.throws() in order to provide the validation argument for the call. PR-URL: #9918 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
In this change, I've added the regex pattern to the assert.throws() in order to provide the validation argument for the call. PR-URL: #9918 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
In this change, I've added the regex pattern to the assert.throws() in order to provide the validation argument for the call. PR-URL: #9918 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
In this change, I've added the regex pattern to the assert.throws()
in order to provide the validation argument for the call.