Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change var declarations, add mustCall check #9962

Closed
wants to merge 3 commits into from
Closed

test: change var declarations, add mustCall check #9962

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b7ece6
test: change var declarations, add mustCall check
Dec 1, 2016
60ba7c8
Removing debug statement
Dec 1, 2016
f139445
test: change let declaration, assertions
Dec 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions test/parallel/test-cluster-net-send.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var fork = require('child_process').fork;
var net = require('net');
const common = require('../common');
const assert = require('assert');
const fork = require('child_process').fork;
const net = require('net');

if (process.argv[2] !== 'child') {
console.error('[%d] master', process.pid);

var worker = fork(__filename, ['child']);
var called = false;
const worker = fork(__filename, ['child']);
let called = false;

worker.once('message', function(msg, handle) {
worker.once('message', common.mustCall(function(msg, handle) {
assert.equal(msg, 'handle');
assert.ok(handle);
worker.send('got');
Expand All @@ -23,26 +23,27 @@ if (process.argv[2] !== 'child') {
handle.on('end', function() {
worker.kill();
});
});
}));

process.once('exit', function() {
console.log('runs');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this console.log statement here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, sure.

assert.ok(called);
});
} else {
console.error('[%d] worker', process.pid);

var socket;
var cbcalls = 0;
let socket;
let cbcalls = 0;
function socketConnected() {
if (++cbcalls === 2)
process.send('handle', socket);
}

var server = net.createServer(function(c) {
process.once('message', function(msg) {
let server = net.createServer(function(c) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this be const?

process.once('message', common.mustCall(function(msg) {
assert.equal(msg, 'got');
c.end('hello');
});
}));
socketConnected();
});
server.listen(common.PORT, function() {
Expand Down