Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-domain-multi #9963

Closed
wants to merge 1 commit into from
Closed

test: refactor test-domain-multi #9963

wants to merge 1 commit into from

Conversation

WesTyler
Copy link
Contributor

@WesTyler WesTyler commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
* assert.equal() -> assert.strictEqual()

Sorry, something went wrong.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@mscdex mscdex added domain Issues and PRs related to the domain subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Dec 1, 2016
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message looks like it references the wrong test.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    * assert.equal() -> assert.strictEqual()
@WesTyler
Copy link
Contributor Author

WesTyler commented Dec 5, 2016

@cjihrig you're right. I amended the commit message with the correct test name. Thanks for catching that.

@addaleax addaleax changed the title test: refactor test-preload test: refactor test-domain-multi Dec 5, 2016
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! I'll land provided CI is happy.

CI: https://ci.nodejs.org/job/node-test-pull-request/5250/

@evanlucas
Copy link
Contributor

Landed in c26419b. Thanks!

@evanlucas evanlucas closed this Dec 6, 2016
evanlucas pushed a commit that referenced this pull request Dec 6, 2016

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Replace assert.equal() with assert.strictEqual().

PR-URL: #9963
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@WesTyler
Copy link
Contributor Author

WesTyler commented Dec 6, 2016

Thanks!

Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Replace assert.equal() with assert.strictEqual().

PR-URL: #9963
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016

Partially verified

This commit is signed with the committer’s verified signature. The key has expired.
addaleax’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Replace assert.equal() with assert.strictEqual().

PR-URL: nodejs#9963
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Replace assert.equal() with assert.strictEqual().

PR-URL: nodejs#9963
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Replace assert.equal() with assert.strictEqual().

PR-URL: #9963
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Replace assert.equal() with assert.strictEqual().

PR-URL: #9963
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Replace assert.equal() with assert.strictEqual().

PR-URL: #9963
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants