tests: update test-tls-no-cert-required #9969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imyller
added
the
code-and-learn
princejwesley
approved these changes
Dec 1, 2016
Change var to const. Wrap callback of createServer with common.mustCall.
rajapanidepu
force-pushed
the
rpanidepu/fixedtest
branch
from
2a81e26
to
d5d7db4
Compare
|
@princejwesley Updated commit message and PR description. |
cjihrig
requested changes
Dec 5, 2016
| this.close(); | ||
| }); | ||
| tls.createServer({ ciphers: 'AECDH-NULL-SHA' }) | ||
| .listen(0, common.mustCall(function() { |
There was a problem hiding this comment.
common.mustCall() is not needed here. If the callback is not called, the server won't be closed, and the test will timeout.
|
The test has since been sufficiently expanded that once this is rebased against master, there are no changes left. I'm going to close this. Thanks for the contribution though! And I'm glad to see your other PR landed! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Change var to const.
Wrap callback of createServer with common.mustCall.