add security release column to index #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse the release notes for a release to determine if it is a security release. Refs: nodejs/Release#437
|
For reference, here's what I get when run locally for 12, 10 and 8: -bash-4.2$ ls ~/sandbox/test
index.json latest-dubnium latest-v4.x npm v10.10.0 v10.14.2 v10.2.1 v10.7.0 v8.0.0 v8.11.2 v8.13.0 v8.16.0 v8.6.0 v8.9.2
index.tab latest-v0.10.x latest-v5.x npm-versions.txt v10.11.0 v10.15.0 v10.3.0 v10.8.0 v8.1.0 v8.11.3 v8.1.4 v8.2.0 v8.7.0 v8.9.3
latest latest-v0.12.x latest-v6.x patch v10.12.0 v10.15.1 v10.4.0 v10.9.0 v8.10.0 v8.11.4 v8.14.0 v8.2.1 v8.8.0 v8.9.4
latest-argon latest-v10.x latest-v7.x robots.txt v10.13.0 v10.15.2 v10.4.1 v12.0.0 v8.1.1 v8.1.2 v8.14.1 v8.3.0 v8.8.1
latest-boron latest-v11.x latest-v8.x v10.0.0 v10.14.0 v10.15.3 v10.5.0 v12.1.0 v8.11.0 v8.12.0 v8.15.0 v8.4.0 v8.9.0
latest-carbon latest-v12.x latest-v9.x v10.1.0 v10.14.1 v10.2.0 v10.6.0 v12.2.0 v8.11.1 v8.1.3 v8.15.1 v8.5.0 v8.9.1
-bash-4.2$ grep '"security":true' ~/sandbox/test/index.json
{"version":"v10.15.2","date":"2019-02-28","files":["aix-ppc64","headers","linux-arm64","linux-armv6l","linux-armv7l","linux-ppc64le","linux-s390x","linux-x64","osx-x64-pkg","osx-x64-tar","src","sunos-x64","win-x64-7z","win-x64-exe","win-x64-msi","win-x64-zip","win-x86-7z","win-x86-exe","win-x86-msi","win-x86-zip"],"npm":"6.4.1","v8":"6.8.275.32","uv":"1.23.2","zlib":"1.2.11","openssl":"1.1.0j","modules":"64","lts":"Dubnium","security":true},
{"version":"v10.14.0","date":"2018-11-28","files":["aix-ppc64","headers","linux-arm64","linux-armv6l","linux-armv7l","linux-ppc64le","linux-s390x","linux-x64","osx-x64-pkg","osx-x64-tar","src","sunos-x64","win-x64-7z","win-x64-exe","win-x64-msi","win-x64-zip","win-x86-7z","win-x86-exe","win-x86-msi","win-x86-zip"],"npm":"6.4.1","v8":"6.8.275.32","uv":"1.23.2","zlib":"1.2.11","openssl":"1.1.0j","modules":"64","lts":"Dubnium","security":true},
{"version":"v8.15.1","date":"2019-03-01","files":["aix-ppc64","headers","linux-arm64","linux-armv6l","linux-armv7l","linux-ppc64le","linux-s390x","linux-x64","linux-x86","osx-x64-pkg","osx-x64-tar","src","sunos-x64","sunos-x86","win-x64-7z","win-x64-exe","win-x64-msi","win-x64-zip","win-x86-7z","win-x86-exe","win-x86-msi","win-x86-zip"],"npm":"6.4.1","v8":"6.2.414.75","uv":"1.23.2","zlib":"1.2.11","openssl":"1.0.2r","modules":"57","lts":"Carbon","security":true},
{"version":"v8.14.0","date":"2018-11-28","files":["aix-ppc64","headers","linux-arm64","linux-armv6l","linux-armv7l","linux-ppc64le","linux-s390x","linux-x64","linux-x86","osx-x64-pkg","osx-x64-tar","src","sunos-x64","sunos-x86","win-x64-7z","win-x64-exe","win-x64-msi","win-x64-zip","win-x86-7z","win-x86-exe","win-x86-msi","win-x86-zip"],"npm":"6.4.1","v8":"6.2.414.72","uv":"1.23.2","zlib":"1.2.11","openssl":"1.0.2q","modules":"57","lts":"Carbon","security":true},
{"version":"v8.11.4","date":"2018-08-16","files":["aix-ppc64","headers","linux-arm64","linux-armv6l","linux-armv7l","linux-ppc64le","linux-s390x","linux-x64","linux-x86","osx-x64-pkg","osx-x64-tar","src","sunos-x64","sunos-x86","win-x64-7z","win-x64-exe","win-x64-msi","win-x64-zip","win-x86-7z","win-x86-exe","win-x86-msi","win-x86-zip"],"npm":"5.6.0","v8":"6.2.414.54","uv":"1.19.1","zlib":"1.2.11","openssl":"1.0.2p","modules":"57","lts":"Carbon","security":true},
{"version":"v8.11.0","date":"2018-03-28","files":["aix-ppc64","headers","linux-arm64","linux-armv6l","linux-armv7l","linux-ppc64le","linux-s390x","linux-x64","linux-x86","osx-x64-pkg","osx-x64-tar","src","sunos-x64","sunos-x86","win-x64-7z","win-x64-exe","win-x64-msi","win-x64-zip","win-x86-7z","win-x86-exe","win-x86-msi","win-x86-zip"],"npm":"5.6.0","v8":"6.2.414.50","uv":"1.19.1","zlib":"1.2.11","openssl":"1.0.2o","modules":"57","lts":"Carbon","security":true},
{"version":"v8.9.3","date":"2017-12-08","files":["aix-ppc64","headers","linux-arm64","linux-armv6l","linux-armv7l","linux-ppc64le","linux-s390x","linux-x64","linux-x86","osx-x64-pkg","osx-x64-tar","src","sunos-x64","sunos-x86","win-x64-7z","win-x64-exe","win-x64-msi","win-x64-zip","win-x86-7z","win-x86-exe","win-x86-msi","win-x86-zip"],"npm":"5.5.1","v8":"6.1.534.48","uv":"1.15.0","zlib":"1.2.11","openssl":"1.0.2n","modules":"57","lts":"Carbon","security":true},
{"version":"v8.1.4","date":"2017-07-11","files":["aix-ppc64","headers","linux-arm64","linux-armv6l","linux-armv7l","linux-ppc64le","linux-s390x","linux-x64","linux-x86","osx-x64-pkg","osx-x64-tar","src","sunos-x64","sunos-x86","win-x64-7z","win-x64-exe","win-x64-msi","win-x64-zip","win-x86-7z","win-x86-exe","win-x86-msi","win-x86-zip"],"npm":"5.0.3","v8":"5.8.283.41","uv":"1.12.0","zlib":"1.2.11","openssl":"1.0.2l","modules":"57","lts":false,"security":true},
-bash-4.2$ |
This was referenced May 10, 2019
|
LGTM |
richardlau
added a commit
to richardlau/node-1
that referenced
this pull request
May 10, 2019
The release commit message for security releases have conventionally started with the phrase `This is a security release.`. Codify this as part of the release process so that the distribution indexer can use this to detect and mark releases as security releases. Fixes: nodejs/Release#437 Refs: nodejs#27612 (comment) Refs: nodejs/nodejs-dist-indexer#9
3 tasks
|
Nice work @richardlau, tests and all. I'm in transit for the next couple of days but will have a play & review with this as soon as I can. |
|
Can someone verify that these changes won’t break nvm’s parsing of the index.tab? |
If it helps, the additional column is added last (after the lts column), e.g.: -bash-4.2$ cat ~/sandbox/test/index.tab
version date files npm v8 uv zlib openssl modules lts security
v12.2.0 2019-05-07 aix-ppc64,headers,linux-arm64,linux-armv7l,linux-ppc64le,linux-s390x,linux-x64,osx-x64-pkg,osx-x64-tar,src,sunos-x64,win-x64-7z,win-x64-exe,win-x64-msi,win-x64-zip,win-x86-7z,win-x86-exe,win-x86-msi,win-x86-zip 6.9.0 7.4.288.21 1.28.0 1.2.11 1.1.1b 72 - -
v12.1.0 2019-04-29 aix-ppc64,headers,linux-arm64,linux-armv7l,linux-ppc64le,linux-s390x,linux-x64,osx-x64-pkg,osx-x64-tar,src,sunos-x64,win-x64-7z,win-x64-exe,win-x64-msi,win-x64-zip,win-x86-7z,win-x86-exe,win-x86-msi,win-x86-zip 6.9.0 7.4.288.21 1.28.0 1.2.11 1.1.1b 72 - -
v12.0.0 2019-04-23 aix-ppc64,headers,linux-arm64,linux-armv7l,linux-ppc64le,linux-s390x,linux-x64,osx-x64-pkg,osx-x64-tar,src,sunos-x64,win-x64-7z,win-x64-exe,win-x64-msi,win-x64-zip,win-x86-7z,win-x86-exe,win-x86-msi,win-x86-zip 6.9.0 7.4.288.21 1.28.0 1.2.11 1.1.1b 72 - -
v10.15.3 2019-03-05 aix-ppc64,headers,linux-arm64,linux-armv6l,linux-armv7l,linux-ppc64le,linux-s390x,linux-x64,osx-x64-pkg,osx-x64-tar,src,sunos-x64,win-x64-7z,win-x64-exe,win-x64-msi,win-x64-zip,win-x86-7z,win-x86-exe,win-x86-msi,win-x86-zip 6.4.1 6.8.275.32 1.23.2 1.2.11 1.1.0j 64 Dubnium -
v10.15.2 2019-02-28 aix-ppc64,headers,linux-arm64,linux-armv6l,linux-armv7l,linux-ppc64le,linux-s390x,linux-x64,osx-x64-pkg,osx-x64-tar,src,sunos-x64,win-x64-7z,win-x64-exe,win-x64-msi,win-x64-zip,win-x86-7z,win-x86-exe,win-x86-msi,win-x86-zip 6.4.1 6.8.275.32 1.23.2 1.2.11 1.1.0j 64 Dubnium true
... |
|
Theoretically that should be fine; nvm's just using |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
May 13, 2019
The release commit message for security releases have conventionally started with the phrase `This is a security release.`. Codify this as part of the release process so that the distribution indexer can use this to detect and mark releases as security releases. Fixes: nodejs/Release#437 Refs: nodejs#27612 (comment) Refs: nodejs/nodejs-dist-indexer#9 PR-URL: nodejs#27643 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
to nodejs/node
that referenced
this pull request
May 14, 2019
The release commit message for security releases have conventionally started with the phrase `This is a security release.`. Codify this as part of the release process so that the distribution indexer can use this to detect and mark releases as security releases. Fixes: nodejs/Release#437 Refs: #27612 (comment) Refs: nodejs/nodejs-dist-indexer#9 PR-URL: #27643 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
good to go, nice narrowing down with the dual regex @richardlau. I'm going to add this to it when I merge and then push it live and see what happens. diff --git a/package.json b/package.json
index 9c0e901..7190c33 100644
--- a/package.json
+++ b/package.json
@@ -18,7 +18,7 @@
"semver": "~5.5.1"
},
"scripts": {
- "test": "node ls-types.js && node transform-filename.js && node decode-ref.js"
+ "test": "node ls-types.js && node transform-filename.js && node decode-ref.js && node is-security-release.js"
},
"bin": {
"nodejs-dist-indexer": "./dist-indexer.js", |
|
ok, live at https://nodejs.org/download/release/index.tab and https://nodejs.org/download/release/index.json, I'd apprecaite some sanity checking that the |
I've checked all of these (via the |
|
"This is a security release" should go into the release instructions now as a requirement now |
Already done in nodejs/node#27643. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the release notes for a release to determine if it is a security
release.
Refs: nodejs/Release#437
Refs: nodejs/node#27612 (comment)
This is an alternative to #8 and can be applied retroactively if the
index is rebuilt. The first line of the release notes should contain
This is a security release.which does appear to be theconvention for the recent security releases AFAICT.