Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-brand "Stable" channel to "Current" #669

Closed
mikeal opened this issue Apr 20, 2016 · 23 comments
Closed

Re-brand "Stable" channel to "Current" #669

mikeal opened this issue Apr 20, 2016 · 23 comments

Comments

@mikeal
Copy link
Contributor

mikeal commented Apr 20, 2016

There's been pretty wide agreement that we should do this for some time, we should pull the trigger before the v6 release.

@MylesBorins
Copy link
Contributor

I'm +1 on this. Who needs to sign off on a change this big? @nodejs/tsc? @nodejs/ctc?

@mscdex
Copy link

mscdex commented Apr 20, 2016

Did we decide on the name "Current?"

@MylesBorins
Copy link
Contributor

fwiw I'm +1 on a change... I'm up for whatever and will avoid getting into the naming bike shed.

"Stable" in particular has been causing some misconceptions.

@evanlucas
Copy link
Contributor

I like "Current"

@mikeal
Copy link
Contributor Author

mikeal commented Apr 20, 2016

@mscdex we have several other threads, mostly around the LTS branding, where we talked about this. A lot of those threads are side tracked by proposing re-branding LTS (which we decided not to do and survey results show that people actually do understand it pretty well) but having "Stable" and "LTS" is still confusing especially when it just isn't accurate.

@mikeal
Copy link
Contributor Author

mikeal commented Apr 20, 2016

oh, also, many other projects use the term "Current" for exactly what we're using it for.

@kahwee
Copy link
Contributor

kahwee commented Apr 20, 2016

"Current" seems to be a better word indeed, since "LTS" is stable too.

@ghost
Copy link

ghost commented Apr 20, 2016

+1 because 'stable' is confusing. LTS is 'stable' too

@ghost
Copy link

ghost commented Apr 20, 2016

also i have a bit of free time, so once this is signed off, can i make the PR?

@jasnell
Copy link
Member

jasnell commented Apr 20, 2016

This is fine. I can add this into the release but since v6 is going out before the next CTC call we'll need to get agreement here. /cc @nodejs/ctc

@Trott
Copy link
Member

Trott commented Apr 20, 2016

I have always found our usage of Stable problematic and am in favor of Current as a replacement.

@mikeal
Copy link
Contributor Author

mikeal commented Apr 20, 2016

go ahead and prepare a PR and we can get whatever signoff necessary.

On Apr 20, 2016, at 2:46PM, 59 notifications@github.com wrote:

also i have a bit of free time, so once this is signed off, can i make the PR?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub #669 (comment)

@MylesBorins
Copy link
Contributor

on it

@MylesBorins
Copy link
Contributor

@mikeal So I sent this simplest PR which is to update the docs in the main repo

We will also have to update the site, I think it might make sense for @fhemberger to handle that or at least someone more familiar with the code base as the word "stable" is used not only in the copy, but in css selectors and hard coded within the tests. That being said I think we should get 100% sign off before that work is done.

As far as I can tell there is nothing that needs to be updated in /download, but perhaps someone from @nodejs/build can verify that for me.

We will also have to update the copy in https://github.com/nodejs/lts

Turns out there is only a single reference to stable, but we'll need to also update the graphic (do you know where that lives @mikeal?). If I can get a copy of a psd or illustrator file I can update that

Those are just the references I knew off the top of my head, I'll do a more in depth search after we get sign off.

@fhemberger
Copy link
Contributor

fhemberger commented Apr 21, 2016

I prepared a PR for this in #672, please have a look …

@ChALkeR
Copy link
Member

ChALkeR commented Apr 21, 2016

+1 on this change.

@fhemberger fhemberger added the pr label Apr 21, 2016
@mhdawson
Copy link
Member

+1 on this change.

@Fishrock123
Copy link
Contributor

Fishrock123 commented Apr 23, 2016

I'm still not ok with this if it directly leads to LTS being called Stable. The Stable/Current release line(s) are intended and maintained so as to be usable, and are not to be taken as experimental. If you want experimental, that is nightlies.

Additionally, if LTS renames to Stable, it's going to be a hell of a time whenever someone looks back at discussions and tries to decipher exactly what we are talking about.

@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 23, 2016 via email

@jasnell
Copy link
Member

jasnell commented Apr 23, 2016

This only impacts the Stable branch naming, not LTS naming.

@Fishrock123
Copy link
Contributor

Right, and we all know that this discussion in the past has not just touched on the stable branch. So I'd like to make sure of it.

@Fishrock123
Copy link
Contributor

Ok. I definitely think we should really take this past evangelism/marketing. I'm afraid a shift without warning may rub off on downstream customers badly and people may be increasingly hesitant about things if we do it with no prior publicly communicated indicator.

MylesBorins pushed a commit to MylesBorins/node that referenced this issue Apr 26, 2016
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

ref: nodejs/nodejs.org#669
jasnell pushed a commit to nodejs/node that referenced this issue Apr 26, 2016
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

Refs: nodejs/nodejs.org#669
PR-URL: #6318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
jasnell pushed a commit to nodejs/node that referenced this issue Apr 26, 2016
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

Refs: nodejs/nodejs.org#669
PR-URL: #6318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@stevemao
Copy link
Contributor

Can we close this since #672 is merged?

MylesBorins pushed a commit to nodejs/node that referenced this issue Jun 1, 2016
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

Refs: nodejs/nodejs.org#669
PR-URL: #6318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Jun 24, 2016
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

Refs: nodejs/nodejs.org#669
PR-URL: #6318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Jun 24, 2016
With v6 we plan to rename the Stable release line to Current.
This commit updates all references to Stable in the codebase. It will
have to land along side updates to other repos within the org.

Refs: nodejs/nodejs.org#669
PR-URL: #6318
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests