Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer missing on Learn layout #6829

Closed
bmuenzenmeyer opened this issue Jun 10, 2024 · 6 comments · Fixed by #6949
Closed

Footer missing on Learn layout #6829

bmuenzenmeyer opened this issue Jun 10, 2024 · 6 comments · Fixed by #6949
Labels

Comments

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Jun 10, 2024

https://nodejs.org/en/learn/getting-started/introduction-to-nodejs

Screenshot_20240610_181426_Chrome.jpg

@mikeesto
Copy link
Member

Same on About too https://nodejs.org/en/about

@Wellitsabhi
Copy link
Contributor

footer missing in 'About and 'Learn" layout , already on it,raising PR

@Wellitsabhi Wellitsabhi mentioned this issue Jun 11, 2024
5 tasks
@ovflowd
Copy link
Member

ovflowd commented Jun 17, 2024

Id say these pages are following the figmas, which have no footer. Now, not sure if we should add or not 🤷

Im fine eitherways.

@bmuenzenmeyer
Copy link
Collaborator Author

I noticed that too but it looks REALLY out of place to me to selectively render a global component. I am surprised it didn't come up earlier, TBH.

@rakeshkumar1019
Copy link
Contributor

@bmuenzenmeyer raised pr for this issue #6949.
can you review the PR.

@velu-murugesan
Copy link

Can you please assign this project or if it is assigned for someone please give me another issue I am new to open source is there any advice or roadmap that is appreciatable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants