-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation workflow to website repository #972
Comments
What a great idea 👍 Thinking we also could deploy such a webhook receiver on the same server we're currently running @nodejs-github-bot. I would be willing to arrange and create an ansible playbook for it. |
Great idea 💡 These problems are discussed in global open source projects.
We need filter 'push' events because we do not need to follow small fix commit. I am not sure whether github-webhook-handler can be hooked if PR has a specific tag like 'breaking change', or not. is it possible ? |
What about just checking to see if the locale has a copy of the file? Many locales only share a few pages with /en/, so this would cut down on the PR's being opened. I'd be interested in tackling this once we decide on an approach. |
A lot of time passed since the issue opened and problem is still here 😢 but we are creating localization tool to help translated ones updated as well. 💯 It's name is GitLocalize. It have been used in "GitHub - vuejs/vue-ssr-docs, GitLocalize - vuejs/vue-ssr-docs" which is one of the Vue.js project and they are very happy with it. So I think it is a time to try our service in Node.js community. We provide these features below:
Looking forward to hearing your thoughts 😄 |
@sotayamashita Wow, this looks really cool. But as always, we need to discuss the access rights to the organization: /cc @mikeal |
@fhemberger Why do they give up using snyk? You can choose public or public and private. (I know each option has a write permission for code.) |
@fhemberger After login, we will request users to choose which repo you want to integrate with "public" or "public and private". We will also add the sentence like "We do not write source code directory" on Term of Service. I have discussed with @mikeal about it and he agreed with the way. Looking forward to hearing your thoughts 🙇 -- |
Awesome! If it doesn't request access to private repos then we should be able to integrate it :) |
@mikeal Thanks. If node.js integrate with our service, can we use your logo on our website? |
@sotayamashita @mikeal Great to see everything seems to work out fine! 🎉 |
@fhemberger Could you integrate the nodejs/nodejs.org to GitLocalize? if you can. |
@sotayamashita I could only access my own repos, but I requested access for the nodejs org. But the message said both public and private repos … |
@fhemberger |
I understand you are so busy but you can only change the permission.
4. Please grant the permission on GitHubAfter opening the page, you will see the page below. please grant the permission because someone has declined before. 5. Please check the permission on GitHubAfter granting the permission, please open the page and then check whether permission is correct or not. If you have any question, please feel free to ask me. Thanks in advance 🙇 |
@sotayamashita Sorry, I tried that before. I only see my own repos in the dropdown, but no repos from the nodejs org. Looks like I don't have enough rights to do that. |
@MylesBorins @Fishrock123 @rvagg @Trott Please grant our app on the page because someone had declined before so we cannnot integrate with normal way. @mikeal has approved the our app. Thanks in advance. 🙇 |
@sotayamashita The "granting access will give this application the ability to access private data" part is giving me pause. If that doesn't refer to private repos, do you know what it does refer to? (Thanks for your patience with all of this.) |
@Trott I am careful not to mistake the meaning so I'll ask about it to GitHuber and share it. |
Updated - We are still talking about "Private data" with GitHub 😢 |
If this grants access to private repos it cannot be enabled. |
Might I recommend a start-up I'm involved with: https://www.bablic.com/ It is a completely non invasive way of tracking changes and performing i10n. It could also be relevant for the i10n of the "meta" docs like the README and CONTRIBUTING guides. RE: nodejs/node#14665 |
@Fishrock123 We understand it. Private permission is not always necessary for our service. GitHub will answer the question @Trott asked |
Updated - We will have a conference call with GitHub. |
@fhemberger and @Trott Updated
|
Closing as all translation efforts are now on Crowdin and discussions should be done there. |
To help translators to stay up-to-date with website changes and additions, it would be great to set up a semi automatic translation workflow:
Issue title:
Issue contents:
After that, each localization team can decide on their own, how to deal with the changes (if they apply to them at all).
The text was updated successfully, but these errors were encountered: