Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation workflow to website repository #972

Closed
fhemberger opened this issue Oct 17, 2016 · 25 comments
Closed

Add translation workflow to website repository #972

fhemberger opened this issue Oct 17, 2016 · 25 comments
Labels
i18n Issues/PRs related to the Website Internationalisation

Comments

@fhemberger
Copy link
Contributor

fhemberger commented Oct 17, 2016

To help translators to stay up-to-date with website changes and additions, it would be great to set up a semi automatic translation workflow:

  1. Use github-webhook-handler to setup a webhook for the repository
  2. Listen to 'push' events
  3. If any commit add/remove/change files in 'locale/en/', use the Node.js GitHub bot account, create one issue in each of the localization team repositories (currently available translations: de (PR), es, it, ja, ko, uk, zh-cn).

Issue title:

  • Filename and status (added/deleted/changed), use a general message for multiple files

Issue contents:

  • Commit message, URL and timestamp
  • Compare link
  • Author/committer

After that, each localization team can decide on their own, how to deal with the changes (if they apply to them at all).

@fhemberger fhemberger added help wanted good first issue Issues for newcomers i18n Issues/PRs related to the Website Internationalisation labels Oct 17, 2016
@phillipj
Copy link
Member

What a great idea 👍

Thinking we also could deploy such a webhook receiver on the same server we're currently running @nodejs-github-bot. I would be willing to arrange and create an ansible playbook for it.

@sotayamashita
Copy link
Contributor

sotayamashita commented Oct 23, 2016

To help translators to stay up-to-date with website changes and additions, it would be great to set up a semi automatic translation workflow:

Great idea 💡 These problems are discussed in global open source projects.

Listen to 'push' events

We need filter 'push' events because we do not need to follow small fix commit. I am not sure whether github-webhook-handler can be hooked if PR has a specific tag like 'breaking change', or not. is it possible ?

@ryanmurakami
Copy link
Contributor

We need filter 'push' events because we do not need to follow small fix commit. I am not sure whether github-webhook-handler can be hooked if PR has a specific tag like 'breaking change', or not. is it possible ?

What about just checking to see if the locale has a copy of the file? Many locales only share a few pages with /en/, so this would cut down on the PR's being opened.

I'd be interested in tackling this once we decide on an approach.

@sotayamashita
Copy link
Contributor

sotayamashita commented May 22, 2017

@fhemberger

A lot of time passed since the issue opened and problem is still here 😢 but we are creating localization tool to help translated ones updated as well. 💯 It's name is GitLocalize.

It have been used in "GitHub - vuejs/vue-ssr-docs, GitLocalize - vuejs/vue-ssr-docs" which is one of the Vue.js project and they are very happy with it. So I think it is a time to try our service in Node.js community. We provide these features below:

  • Have a split view to make people translate
  • When original one is updated, we will notify translators
  • Translation flow looks like a GitHub flow:
    1. Sync GitHub and GitLocalize
    2. Translate
    3. Create a review request such as Pull Request of GitHub
    4. GitLocalize will create pull request to GitHub repository
    5. And merge. That's it ✨

Looking forward to hearing your thoughts 😄

@fhemberger
Copy link
Contributor Author

@sotayamashita Wow, this looks really cool. But as always, we need to discuss the access rights to the organization:

untitled-1

/cc @mikeal

@sotayamashita
Copy link
Contributor

sotayamashita commented Jun 16, 2017

@fhemberger Why do they give up using snyk? You can choose public or public and private. (I know each option has a write permission for code.)

@sotayamashita
Copy link
Contributor

sotayamashita commented Jun 21, 2017

@fhemberger
We have launched the new way to integrate with repositories. ✨

After login, we will request users to choose which repo you want to integrate with "public" or "public and private". We will also add the sentence like "We do not write source code directory" on Term of Service. I have discussed with @mikeal about it and he agreed with the way.

Looking forward to hearing your thoughts 🙇

--
@mikeal
Please correct me if I'm wrong.

@mikeal
Copy link
Contributor

mikeal commented Jun 21, 2017

Awesome! If it doesn't request access to private repos then we should be able to integrate it :)

@sotayamashita
Copy link
Contributor

@mikeal Thanks. If node.js integrate with our service, can we use your logo on our website?

@fhemberger
Copy link
Contributor Author

@sotayamashita @mikeal Great to see everything seems to work out fine! 🎉

@sotayamashita
Copy link
Contributor

@fhemberger Could you integrate the nodejs/nodejs.org to GitLocalize? if you can.

@fhemberger
Copy link
Contributor Author

@sotayamashita I could only access my own repos, but I requested access for the nodejs org. But the message said both public and private repos …

@sotayamashita
Copy link
Contributor

sotayamashita commented Jun 25, 2017

@fhemberger
I checked your scope and it is user:email,public_repo. Could you share the screen shot of the message?

@sotayamashita
Copy link
Contributor

sotayamashita commented Jun 26, 2017

@fhemberger
@rvagg

I understand you are so busy but you can only change the permission.

### 1. Please sigh up on GitLocalize with GitHub
### 2. Please open the page to add repository
### 3. Please grant permission on GitLocalize

4. Please grant the permission on GitHub

After opening the page, you will see the page below. please grant the permission because someone has declined before.

screen shot 2017-06-26 at 10 21 35 pm

5. Please check the permission on GitHub

After granting the permission, please open the page and then check whether permission is correct or not.

screen shot 2017-06-26 at 10 27 48 pm

If you have any question, please feel free to ask me. Thanks in advance 🙇

@fhemberger
Copy link
Contributor Author

@sotayamashita Sorry, I tried that before. I only see my own repos in the dropdown, but no repos from the nodejs org. Looks like I don't have enough rights to do that.

@sotayamashita
Copy link
Contributor

sotayamashita commented Jun 29, 2017

@MylesBorins @Fishrock123 @rvagg @Trott

Please grant our app on the page because someone had declined before so we cannnot integrate with normal way. @mikeal has approved the our app.

screen shot 2017-06-26 at 10 21 35 pm

Thanks in advance. 🙇

@Trott
Copy link
Member

Trott commented Jun 29, 2017

@sotayamashita The "granting access will give this application the ability to access private data" part is giving me pause. If that doesn't refer to private repos, do you know what it does refer to?

(Thanks for your patience with all of this.)

@sotayamashita
Copy link
Contributor

sotayamashita commented Jun 29, 2017

@Trott I am careful not to mistake the meaning so I'll ask about it to GitHuber and share it.

@sotayamashita
Copy link
Contributor

sotayamashita commented Aug 1, 2017

Updated - We are still talking about "Private data" with GitHub 😢

@Fishrock123
Copy link
Contributor

If this grants access to private repos it cannot be enabled.

@refack
Copy link
Contributor

refack commented Aug 7, 2017

Might I recommend a start-up I'm involved with: https://www.bablic.com/ It is a completely non invasive way of tracking changes and performing i10n.

It could also be relevant for the i10n of the "meta" docs like the README and CONTRIBUTING guides. RE: nodejs/node#14665

@sotayamashita
Copy link
Contributor

@Fishrock123 We understand it. Private permission is not always necessary for our service. GitHub will answer the question @Trott asked

@sotayamashita
Copy link
Contributor

Updated - We will have a conference call with GitHub.

@sotayamashita
Copy link
Contributor

@fhemberger and @Trott

Updated

I am struggling to do it. It will take time to solve the problem between GitHub and GitLocalize. If we take too much time, I think I will give up integrating with Node.js at the moment but I will create an issue when we solve the problem.

nodejs/community-committee#114 (comment)

@ovflowd
Copy link
Member

ovflowd commented Mar 12, 2023

Closing as all translation efforts are now on Crowdin and discussions should be done there.

@ovflowd ovflowd closed this as completed Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Issues/PRs related to the Website Internationalisation
Projects
None yet
Development

No branches or pull requests

9 participants