Anchor links

[fabiosantoscode]

Okay, this implements anchor links in headings from markdown text!

I love anchor links, so I really had to do this one.

[fabiosantoscode]

(Fixes #52)

[fhemberger]

Great idea, still needs some fine tuning (see the link on the bottom right):

https://nodejs.org/en/about/working-groups/#website

Also a little bit of padding would be nice, so the hash doesn't touch the headline. Maybe also a more subtile hover style for those links without the green background?

[fabiosantoscode]

Yes, good idea. The font might be too bold too.

[phillipj]

Nice, looking forward to this landing 👍

On Monday, September 14, 2015, Fábio Santos notifications@github.com
wrote:

Yes, good idea. The font might be too bold too.

—
Reply to this email directly or view it on GitHub
#143 (comment)
.

[mrkiffie]

I've forked @fabiosantoscode's branch here, resolved conflicts and extended the renderer function to support markdown headings that contain links. Here is the comparison with master. Any thoughts?

[phillipj]

Nice refactoring w/tests @mrkiffie 👍 Maybe you could address the styling issues @fhemberger pointed out aswell while you're at it?

Also a little bit of padding would be nice, so the hash doesn't touch the headline. Maybe also a more subtile hover style for those links without the green background?

[mrkiffie]

Ok, I'll have a look at those style tweaks

[mrkiffie]

@phillipj, I've updated the styles to be similar to those of the attachment in #52.
I also simplified the markup that was being generated as it doesn't appear to serve a purpose.

[phillipj]

Very nice @mrkiffie! I would say your branch looks mergeable after squashing your commits into one and opening a PR from your fork.

[phillipj]

Fixed with 294af4f, thanks to both of you 👍