Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix styles of hbs files #1722

Merged
merged 1 commit into from Jul 9, 2018
Merged

[Fix] Fix styles of hbs files #1722

merged 1 commit into from Jul 9, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 9, 2018

Because there is something wrong in formation, and when we run npm run test we cannot continue:
error
This is the fixture for that:
success

@ghost ghost requested a review from fhemberger July 9, 2018 07:46
@ghost ghost added the bug label Jul 9, 2018
Copy link
Contributor

@fhemberger fhemberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little nit: You could remove the second space (after }}).

Because there are something wrong in formation, and when we run `npm run test` we cannot continue.

This is the fixture for that.
@ghost
Copy link
Author

ghost commented Jul 9, 2018

OK, done. Thanks for tips

@fhemberger fhemberger merged commit 2b73296 into nodejs:master Jul 9, 2018
@fhemberger
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant