-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update what-is-json.md #2081
Update what-is-json.md #2081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for some nits :)
@@ -14,11 +14,13 @@ has become the defacto standard for the web. JSON can be represented | |||
as either a list of values, e.g. an Array, or a hash of properties and | |||
values, e.g. an Object. | |||
|
|||
// a JSON array | |||
["one", "two", "three"] | |||
```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about changing to 'json' instead of 'js' here? Because this is a pure 'json' formation :)
@@ -67,38 +73,42 @@ format. There are several gotchas that can produce invalid JSON as well. | |||
|
|||
These are all examples of valid JSON. | |||
|
|||
{"name":"John Doe","age":32,"title":"Vice President of JavaScript"} | |||
```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about changing to 'json' instead of 'js' here? Because this is a pure 'json' formation :)
|
||
These are all examples of bad JSON formatting. | ||
|
||
{ name: "John Doe", 'age': 32 } // name and age should be in double quotes | ||
```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about changing to 'json' instead of 'js' here? Because this is a pure 'json' formation :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out these changes. Totaly slipped from my mind :)
Linking to a JSON validator is probably a good idea. You could link to jsonlint.com, mention the |
Added the validator section in the Article and fixed minor errors
fix 'age' property with double quotes
Cool! Thank you👍 |
Hey @chowdhurian and @fhemberger,
In accordance with issue #1977, I have updated the Article what-is-json with the following changes:
If there are any suggestion/enhancement/tips please feel free to tell me, I would love to incorporate those changes in this Article 😄
Note: Let me know if a link to json.org and a JSON validator like jsonlint should be added (do suggest the validator)