Update what-is-the-arguments-object.md #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed a semi-colon (;)
ghost
approved these changes
Feb 17, 2019
fhemberger
suggested changes
Feb 17, 2019
| } | ||
| ```js | ||
| const myfunc = function(one) { | ||
| arguments.callee === myfunc; |
There was a problem hiding this comment.
arguments.callee has been deprecated in ES5 strict mode:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/arguments/callee
| args.push(arguments[i]); | ||
| } | ||
|
|
||
| // for ES6 and above |
There was a problem hiding this comment.
Maybe we should push this as the default for current Node.js versions (and only mention the pre-ES6 variants briefly). What do you think?
There was a problem hiding this comment.
Thanks, @fhemberger for the advice will update both the sections :)
Updated the 2 sections, about callee property and for loop.
fhemberger
approved these changes
Feb 19, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @chowdhurian and @fhemberger,
In accordance with issue #1977, I have updated the Article what-is-the-arguments-object with the following changes:
arrow functionexception and its workaround (rest parameter)Array.from()method usage.If there are any suggestion/enhancement/tips please feel free to tell me, I would love to incorporate those changes in this Article 😄