Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ar: translation for "docs/guides/index.md" #2139

Merged
1 commit merged into from
Mar 7, 2019
Merged

Conversation

Aissaoui-Ahmed
Copy link
Contributor

@Aissaoui-Ahmed Aissaoui-Ahmed commented Mar 5, 2019

Arabic translation for docs/guides/index.md.

@celyes @ouadie-lahdioui @InterstellarClub

locale/ar/docs/index.md Outdated Show resolved Hide resolved
@celyes
Copy link
Contributor

celyes commented Mar 6, 2019

Looks good to me 👍

@ghost ghost changed the title AR: translation for "docs/index.md" AR ar: translation for "docs/guides/index.md" Mar 6, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ghost
ghost previously requested changes Mar 6, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be "docs/guides/index.md" instead of "docs/index.md", please update all of your files locally and see what's the difference between 'docs/index.md' and 'docs/guides/index.md'. I think you should add this file into the 'docs/guides/', compared with the English one.

question

@ghost ghost self-requested a review March 6, 2019 23:30
@Aissaoui-Ahmed Aissaoui-Ahmed dismissed ghost ’s stale review March 6, 2019 23:58

I'm trying to focus on translation 😵 ! thank you @ maledong

@ghost
Copy link

ghost commented Mar 7, 2019

@ouadie-lahdioui:Anything else?

Copy link
Contributor

@ouadie-lahdioui ouadie-lahdioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants