Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.js: don't copy site.json files in the output dir #2618

Merged
merged 2 commits into from
Oct 9, 2019
Merged

build.js: don't copy site.json files in the output dir #2618

merged 2 commits into from
Oct 9, 2019

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Sep 29, 2019

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 3, 2019

Can someone confirm that the json files are not needed on the live site?

@Aissaoui-Ahmed
Copy link
Contributor

NEWS link on other languages not rending blog(EN)

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 4, 2019

Where is that code? AFAICT everything is built on build time. I added a live Preview with this patch: https://dazzling-minsky-3c0d14.netlify.com/en/

Give it some time to go live

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 4, 2019

Also, note that this only removes site.json from the build dir, not the source dir.

Copy link
Contributor

@Aissaoui-Ahmed Aissaoui-Ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed ! not necessary file site.json in Build dir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop outputting site.json in the build dir
3 participants