Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

category-index.hbs: fix generation on Windows #2629

Merged
merged 5 commits into from
Oct 12, 2019
Merged

category-index.hbs: fix generation on Windows #2629

merged 5 commits into from
Oct 12, 2019

Conversation

XhmikosR
Copy link
Contributor

I would seriously like to get this fixed where it's broken, but it's either metalsmith-collections or metalsmith itself AFAICT...

Anyway, I hope this is the last place :/

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 8, 2019

BTW I've pinpointed the root cause of the Windows backslashes on metalsmith/permalinks. I have submitted upstream patches, and there's one Windows test failure which is causing exactly these issues we hit here.

@XhmikosR XhmikosR requested a review from SEWeiTung October 9, 2019 10:32
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Oct 9, 2019

This was noticeable in http://localhost:8080/en/blog/announcements/:

Screenshot_2019-10-09 Announcements Node js

On *nix the behavior should be the same, but someone should try just to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants